Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: chrome/browser/extensions/extension_host.cc

Issue 9235002: Enable devtools via context menu in platform apps and popup extensions. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Comment typo Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_host.h ('k') | chrome/browser/extensions/platform_app_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_host.cc
diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc
index 2714b0b4a83b340ed79fd039777aa0b9239b61ad..d2d5c7da35da2755ba32474ab45b9396c8810b70 100644
--- a/chrome/browser/extensions/extension_host.cc
+++ b/chrome/browser/extensions/extension_host.cc
@@ -45,7 +45,6 @@
#include "ui/base/keycodes/keyboard_codes.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
-#include "webkit/glue/context_menu.h"
#if defined(TOOLKIT_VIEWS)
#include "ui/views/widget/widget.h"
@@ -427,17 +426,6 @@ WebContents* ExtensionHost::OpenURLFromTab(WebContents* source,
}
}
-bool ExtensionHost::HandleContextMenu(const ContextMenuParams& params) {
- // Only allow context menus on non-linked editable items and selections.
- // Context entries for the page and "Save * as..." are currently unsupported.
- bool has_link = !params.unfiltered_link_url.is_empty();
- bool has_selection = !params.selection_text.empty();
- bool editable = params.is_editable;
- bool media = params.media_type != WebKit::WebContextMenuData::MediaTypeNone;
- // Returning true suppresses the context menu, having been "handled" here.
- return has_link || media || !(editable || has_selection);
-}
-
bool ExtensionHost::PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
bool* is_keyboard_shortcut) {
if (extension_host_type_ == chrome::VIEW_TYPE_EXTENSION_POPUP &&
« no previous file with comments | « chrome/browser/extensions/extension_host.h ('k') | chrome/browser/extensions/platform_app_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698