Enable devtools via context menu in platform apps and popup extensions.

chrome/browser/tab_contents/render_view_context_menu.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
 
@@ skipping 507 matching lines @@
   for (i = sorted_ids.begin();
        i != sorted_ids.end(); ++i) {
     AppendExtensionItems(i->second, &index);
   }
   UMA_HISTOGRAM_TIMES("Extensions.ContextMenus_BuildTime",
                       base::TimeTicks::Now() - begin);
   UMA_HISTOGRAM_COUNTS("Extensions.ContextMenus_ItemCount", index);
 }
 
 void RenderViewContextMenu::InitMenu() {
-  if (GetPlatformApp()) {
-    AppendPlatformAppItems();
+  const Extension* extension = GetExtension();
+  if (extension) {
+    if (extension->is_platform_app())
+      AppendPlatformAppItems(extension);
+    else
+      AppendPopupExtensionItems();
     return;
   }
 
   bool has_link = !params_.unfiltered_link_url.is_empty();
   bool has_selection = !params_.selection_text.empty();
 
   if (AppendCustomItems()) {
     // If there's a selection, don't early return when there are custom items,
     // but fall through to adding the normal ones after the custom ones.
     if (has_selection) {
@@ skipping 50 matching lines @@
       break;
     case WebContextMenuData::MediaTypePlugin:
       AppendPluginItems();
       break;
 #ifdef WEBCONTEXT_MEDIATYPEFILE_DEFINED
     case WebContextMenuData::MediaTypeFile:
       break;
 #endif
   }
 
-  if (params_.is_editable) {
-    // Add a menu item that shows suggestions.
-    if (!spelling_menu_observer_.get()) {
-      spelling_menu_observer_.reset(new SpellingMenuObserver(this));
-    }
-    if (spelling_menu_observer_.get()) {
-      observers_.AddObserver(spelling_menu_observer_.get());
-      spelling_menu_observer_->InitMenu(params_);
-    }
-  }
-
   if (params_.is_editable)
     AppendEditableItems();
   else if (has_selection)
     AppendCopyItem();
 
   if (has_selection)
     AppendSearchProvider();
 
   if (!IsDevToolsURL(params_.page_url))
     AppendAllExtensionItems();
 
   AppendDeveloperItems();
 
   if (!print_preview_menu_observer_.get()) {
     TabContentsWrapper* wrapper =
         TabContentsWrapper::GetCurrentWrapperForContents(source_web_contents_);
     print_preview_menu_observer_.reset(
         new PrintPreviewContextMenuObserver(wrapper));
   }
   observers_.AddObserver(print_preview_menu_observer_.get());
 }
 
-const Extension* RenderViewContextMenu::GetPlatformApp() const {
+const Extension* RenderViewContextMenu::GetExtension() const {
   ExtensionProcessManager* process_manager =
       profile_->GetExtensionProcessManager();
   // There is no process manager in some tests.
   if (!process_manager) {
     return NULL;
   }
 
   ExtensionProcessManager::const_iterator iter;
   for (iter = process_manager->begin(); iter != process_manager->end();
        ++iter) {
     ExtensionHost* host = *iter;
-    if (host->host_contents() == source_web_contents_) {
-      if (host->extension() && host->extension()->is_platform_app()) {
-        return host->extension();
-      }
-    }
+    if (host->host_contents() == source_web_contents_)
+      return host->extension();
   }
 
   return NULL;
 }
 
-void RenderViewContextMenu::AppendPlatformAppItems() {
-  const Extension* platform_app = GetPlatformApp();
+void RenderViewContextMenu::AppendPlatformAppItems(
+    const Extension* platform_app) {
   DCHECK(platform_app);
   int index = 0;
   AppendExtensionItems(platform_app->id(), &index);
+
+  // Add dev tools for unpacked extensions.
+  if (platform_app->location() == Extension::LOAD)
+    AppendDeveloperItems();
+}
+
+void RenderViewContextMenu::AppendPopupExtensionItems() {
+  bool has_selection = !params_.selection_text.empty();
+
+  if (params_.is_editable)
+    AppendEditableItems();
+  else if (has_selection)
+    AppendCopyItem();
+
+  if (has_selection)
+    AppendSearchProvider();
+
+  AppendAllExtensionItems();
+  AppendDeveloperItems();
 }
 
 void RenderViewContextMenu::LookUpInDictionary() {
   // Used only in the Mac port.
   NOTREACHED();
 }
 
 void RenderViewContextMenu::AddMenuItem(int command_id,
                                         const string16& title) {
   menu_model_.AddItem(command_id, title);
@@ skipping 238 matching lines @@
       return;
     menu_model_.AddItem(
         IDC_CONTENT_CONTEXT_SEARCHWEBFOR,
         l10n_util::GetStringFUTF16(IDS_CONTENT_CONTEXT_SEARCHWEBFOR,
                                    default_provider->short_name(),
                                    printable_selection_text));
   }
 }
 
 void RenderViewContextMenu::AppendEditableItems() {
+  AppendSpellingSuggestionsSubMenu();
+
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_UNDO,
                                   IDS_CONTENT_CONTEXT_UNDO);
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_REDO,
                                   IDS_CONTENT_CONTEXT_REDO);
   menu_model_.AddSeparator();
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_CUT,
                                   IDS_CONTENT_CONTEXT_CUT);
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_COPY,
                                   IDS_CONTENT_CONTEXT_COPY);
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_PASTE,
@@ skipping 18 matching lines @@
   // languages.
   // This functionality is exposed as a keyboard shortcut on Windows & Linux.
   AppendBidiSubMenu();
 #endif  // OS_MACOSX
 
   menu_model_.AddSeparator();
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_SELECTALL,
                                   IDS_CONTENT_CONTEXT_SELECTALL);
 }
 
+void RenderViewContextMenu::AppendSpellingSuggestionsSubMenu() {
+  if (!spelling_menu_observer_.get())
+    spelling_menu_observer_.reset(new SpellingMenuObserver(this));
+  observers_.AddObserver(spelling_menu_observer_.get());
+  spelling_menu_observer_->InitMenu(params_);
+}
+
 void RenderViewContextMenu::AppendSpellcheckOptionsSubMenu() {
   if (!spellchecker_submenu_observer_.get()) {
     spellchecker_submenu_observer_.reset(new SpellCheckerSubMenuObserver(
         this, this, kSpellcheckRadioGroup));
   }
-  if (spellchecker_submenu_observer_.get()) {
-    spellchecker_submenu_observer_->InitMenu(params_);
-    observers_.AddObserver(spellchecker_submenu_observer_.get());
-  }
+  spellchecker_submenu_observer_->InitMenu(params_);
+  observers_.AddObserver(spellchecker_submenu_observer_.get());
 }
 
 void RenderViewContextMenu::AppendSpeechInputOptionsSubMenu() {
   if (params_.speech_input_enabled) {
     speech_input_submenu_model_.AddCheckItem(
         IDC_CONTENT_CONTEXT_SPEECH_INPUT_FILTER_PROFANITIES,
         l10n_util::GetStringUTF16(
             IDS_CONTENT_CONTEXT_SPEECH_INPUT_FILTER_PROFANITIES));
 
     speech_input_submenu_model_.AddItemWithStringId(
@@ skipping 890 matching lines @@
   if (view)
     view->ShowingContextMenu(false);
   RenderViewHost* rvh = source_web_contents_->GetRenderViewHost();
   if (rvh) {
     rvh->NotifyContextMenuClosed(params_.custom_context);
   }
 }
 
 bool RenderViewContextMenu::IsDevCommandEnabled(int id) const {
   if (id == IDC_CONTENT_CONTEXT_INSPECTELEMENT) {
-    const CommandLine& command_line = *CommandLine::ForCurrentProcess();
-    TabContentsWrapper* tab_contents_wrapper =
-        TabContentsWrapper::GetCurrentWrapperForContents(
-            source_web_contents_);
-    if (!tab_contents_wrapper)
-      return false;
-    // Don't enable the web inspector if JavaScript is disabled.
-    if (!tab_contents_wrapper->prefs_tab_helper()->per_tab_prefs()->GetBoolean(
-            prefs::kWebKitJavascriptEnabled) ||
-        command_line.HasSwitch(switches::kDisableJavaScript))
-      return false;
+    // Don't enable the web inspector if JavaScript is disabled. We don't
+    // check this when this is the web contents of an extension (e.g.
+    // for a popup extension or a platform app) as they have JavaScript
+    // always enabled.
+    const Extension* extension = GetExtension();
+    if (!extension) {
+      TabContentsWrapper* contents_wrapper =
+          TabContentsWrapper::GetCurrentWrapperForContents(
+              source_web_contents_);
+      if (!contents_wrapper)
+        return false;
+      const CommandLine* command_line = CommandLine::ForCurrentProcess();
+      if (!contents_wrapper->prefs_tab_helper()->per_tab_prefs()->GetBoolean(
+              prefs::kWebKitJavascriptEnabled) ||
+          command_line->HasSwitch(switches::kDisableJavaScript))
+        return false;
+#if !defined(TOOLKIT_VIEWS)
+    } else {
+      // Disable dev tools for popup extensions for non-views builds, as the
+      // extension popups for these builds do not support dynamically inspecting
+      // the popups.
+      // TODO(benwells): Add support for these builds and remove this #if.
+      if (!extension->is_platform_app())
+        return false;
+#endif
+    }
+
     // Don't enable the web inspector if the developer tools are disabled via
     // the preference dev-tools-disabled.
     if (profile_->GetPrefs()->GetBoolean(prefs::kDevToolsDisabled))
       return false;
   }
 
   return true;
 }
 
 string16 RenderViewContextMenu::PrintableSelectionText() {
@@ skipping 49 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }