Enable devtools via context menu in platform apps and popup extensions.

chrome/browser/ui/views/extensions/extension_popup.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_popup.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "chrome/browser/debugger/devtools_window.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
@@ skipping 39 matching lines @@
   set_close_on_deactivate(!inspect_with_devtools);
 #endif
 
   // Wait to show the popup until the contained host finishes loading.
   registrar_.Add(this, content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
                  content::Source<WebContents>(host->host_contents()));
 
   // Listen for the containing view calling window.close();
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE,
                  content::Source<Profile>(host->profile()));
+
+  if (!inspect_with_devtools_) {
+    // Listen for the dev tools opening on this popup, so we can stop it going
+    // away when the dev tools get focus.
+    registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_WINDOW_OPENING,
+                   content::Source<Profile>(host->profile()));
+  }
 }
 
 ExtensionPopup::~ExtensionPopup() {
   views::WidgetFocusManager::GetInstance()->RemoveFocusChangeListener(this);
 }
 
 void ExtensionPopup::Observe(int type,
                              const content::NotificationSource& source,
                              const content::NotificationDetails& details) {
   switch (type) {
     case content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME:
       DCHECK(content::Source<WebContents>(host()->host_contents()) == source);
       // Show when the content finishes loading and its width is computed.
       ShowBubble();
       break;
     case chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE:
       // If we aren't the host of the popup, then disregard the notification.
       if (content::Details<ExtensionHost>(host()) == details)
         GetWidget()->Close();
       break;
     case content::NOTIFICATION_DEVTOOLS_WINDOW_CLOSING:
       // Make sure its the devtools window that inspecting our popup.
       // Widget::Close posts a task, which should give the devtools window a
       // chance to finish detaching from the inspected RenderViewHost.
-      if (content::Details<RenderViewHost>(
-              host()->render_view_host()) == details)
+      if (content::Details<RenderViewHost>(host()->render_view_host()) ==
+          details) {

[msw, 2012/02/03 07:57:24]

nit: Braces here are optional, not necessary.

[benwells, 2012/02/06 03:40:46]

OK. I think with the if conditional spread over two lines the braces improve
clarity. Unless you object I'll leave them in.

         GetWidget()->Close();
+      }
+      break;
+    case content::NOTIFICATION_DEVTOOLS_WINDOW_OPENING:
+      // First check that the devtools are being opened on this popup.
+      if (content::Details<RenderViewHost>(host()->render_view_host()) ==
+          details) {
+        // Set inspect_with_devtools_ so the popup will be kept open while

[msw, 2012/02/03 07:57:24]

Does this work? I think you'll need to call set_close_on_deactivate(false);

[benwells, 2012/02/06 03:40:46]

Thanks, it will need that to work on chromeos and aura.

Done.

+        // the devtools are open.
+        inspect_with_devtools_ = true;
+        // Listen for the devtools being closed so the popup can be closed.
+        registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_WINDOW_CLOSING,

[msw, 2012/02/03 07:57:24]

optional: consider replacing this statement and the duplicate in
ExtensionPopup::ShowBubble with an unconditional call in the ctor.

[benwells, 2012/02/06 03:40:46]

Done.

+            content::Source<content::BrowserContext>(host()->profile()));
+      }
       break;
     default:
       NOTREACHED() << L"Received unexpected notification";
   }
 }
 
 void ExtensionPopup::OnExtensionPreferredSizeChanged(ExtensionView* view) {
   SizeToContents();
 }
 
@@ skipping 56 matching lines @@
   views::WidgetFocusManager::GetInstance()->AddFocusChangeListener(this);
 
   if (inspect_with_devtools_) {
     // Listen for the the devtools window closing.
     registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_WINDOW_CLOSING,
         content::Source<content::BrowserContext>(host()->profile()));
     DevToolsWindow::ToggleDevToolsWindow(host()->render_view_host(),
         DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE);
   }
 }