Chromium Code Reviews| Index: chrome/browser/extensions/execute_script_apitest.cc |
| diff --git a/chrome/browser/extensions/execute_script_apitest.cc b/chrome/browser/extensions/execute_script_apitest.cc |
| index 3a5e92a7f5121195cb2c10c432680219ed4e0dfb..abb7e16855a65726d987b8f13db89e8660fb36c0 100644 |
| --- a/chrome/browser/extensions/execute_script_apitest.cc |
| +++ b/chrome/browser/extensions/execute_script_apitest.cc |
| @@ -15,27 +15,15 @@ class ExecuteScriptApiTest : public ExtensionApiTest { |
| } |
| }; |
| -// DISABLED http://crbug.com/92105 |
| -#if defined(OS_CHROMEOS) |
| -#define MAYBE_ExecuteScriptBasic DISABLED_ExecuteScriptBasic |
| -#else |
| -#define MAYBE_ExecuteScriptBasic ExecuteScriptBasic |
| -#endif // defined(OS_CHROMEOS) |
| - |
| -IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, MAYBE_ExecuteScriptBasic) { |
| +// If failing, disable and update http://crbug.com/92105. |
| +IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, ExecuteScriptBasic) { |
|
asargent_no_longer_on_chrome
2012/02/29 18:20:52
These changes look unrelated to offscreen tabs. Cr
jstritar
2012/03/12 14:53:06
Done.
|
| SetupDelayedHostResolver(); |
| ASSERT_TRUE(StartTestServer()); |
| ASSERT_TRUE(RunExtensionTest("executescript/basic")) << message_; |
| } |
| -// DISABLED http://crbug.com/92105 |
| -#if defined(OS_CHROMEOS) |
| -#define MAYBE_ExecuteScriptInFrame DISABLED_ExecuteScriptInFrame |
| -#else |
| -#define MAYBE_ExecuteScriptInFrame ExecuteScriptInFrame |
| -#endif // defined(OS_CHROMEOS) |
| - |
| -IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, MAYBE_ExecuteScriptInFrame) { |
| +// If failing, disable and update http://crbug.com/92105. |
| +IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, ExecuteScriptInFrame) { |
| SetupDelayedHostResolver(); |
| ASSERT_TRUE(StartTestServer()); |
| ASSERT_TRUE(RunExtensionTest("executescript/in_frame")) << message_; |
| @@ -47,23 +35,17 @@ IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, ExecuteScriptPermissions) { |
| ASSERT_TRUE(RunExtensionTest("executescript/permissions")) << message_; |
| } |
| -// http://crbug.com/84760 |
| -#if defined(OS_CHROMEOS) |
| -#define MAYBE_ExecuteScriptFileAfterClose DISABLED_ExecuteScriptFileAfterClose |
| -#else |
| -#define MAYBE_ExecuteScriptFileAfterClose ExecuteScriptFileAfterClose |
| -#endif // defined(OS_CHROMEOS) |
| - |
| +// If failing, disable and update http://crbug.com/84760. |
| IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, |
| - MAYBE_ExecuteScriptFileAfterClose) { |
| + ExecuteScriptFileAfterClose) { |
| host_resolver()->AddRule("b.com", "127.0.0.1"); |
| ASSERT_TRUE(StartTestServer()); |
| ASSERT_TRUE(RunExtensionTest("executescript/file_after_close")) << message_; |
| } |
| -// Crashy, http://crbug.com/67774. |
| +// If crashing, disable and update http://crbug.com/67774. |
| IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, |
| - DISABLED_ExecuteScriptFragmentNavigation) { |
| + ExecuteScriptFragmentNavigation) { |
| ASSERT_TRUE(StartTestServer()); |
| const char* extension_name = "executescript/fragment"; |
| ASSERT_TRUE(RunExtensionTest(extension_name)) << message_; |
| @@ -85,15 +67,9 @@ IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, NavigationRaceJavaScriptURL) { |
| "javascript_url.html")) << message_; |
| } |
| -// DISABLED http://crbug.com/92105 |
| -#if defined(OS_CHROMEOS) |
| -#define MAYBE_ExecuteScriptFrameAfterLoad DISABLED_ExecuteScriptFrameAfterLoad |
| -#else |
| -#define MAYBE_ExecuteScriptFrameAfterLoad ExecuteScriptFrameAfterLoad |
| -#endif // defined(OS_CHROMEOS) |
| - |
| +// If failing, disable and update http://crbug.com/92105. |
| IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, |
| - MAYBE_ExecuteScriptFrameAfterLoad) { |
| + ExecuteScriptFrameAfterLoad) { |
| SetupDelayedHostResolver(); |
| ASSERT_TRUE(StartTestServer()); |
| ASSERT_TRUE(RunExtensionTest("executescript/frame_after_load")) << message_; |