Add summary of failures to end of test.dart output.

tools/testing/dart/test_progress.dart

Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index 2fb056b0cae5080dc4b3117c262622e49053dbff..0b05726a30af7f4dc4de77581801cc646777423c 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -8,7 +8,8 @@
 #import("test_suite.dart");
 
 class ProgressIndicator {
-  ProgressIndicator(this._startTime, this._printTiming) : _tests = [];
+  ProgressIndicator(this._startTime, this._printTiming)
+      : _tests = [], _failureSummary = [];
 
   factory ProgressIndicator.fromName(String name,
                                      Date startTime,
@@ -74,6 +75,7 @@ class ProgressIndicator {
   }
 
   void allDone() {
+    _printFailureSummary();
     _printStatus();
     _printTimingInformation();
     exit(_failedTests > 0 ? 1 : 0);
@@ -108,27 +110,49 @@ class ProgressIndicator {
   }
 
   void _printFailureOutput(TestCase test) {
-    print('\nFAILED: ${test.displayName}');
+    List<String> output = new List<String>();
+    output.add('');
+    output.add('FAILED: ${test.displayName}');
     StringBuffer expected = new StringBuffer();
     expected.add('Expected: ');
     for (var expectation in test.expectedOutcomes) {
       expected.add('$expectation ');
     }
-    print(expected.toString());
-    print('Actual: ${test.output.result}');
+    output.add(expected.toString());
+    output.add('Actual: ${test.output.result}');
     if (!test.output.stdout.isEmpty()) {
-      print('\nstdout:');
-      test.output.stdout.forEach((s) => print(s));
+      output.add('');
+      output.add('stdout:');
+      for (var s in test.output.stdout) {
+        output.add(s);
+      }
     }
     if (!test.output.stderr.isEmpty()) {
-      print('\nstderr:');
-      test.output.stderr.forEach((s) => print(s));
+      output.add('');
+      output.add('stderr:');
+      for (var s in test.output.stderr) {
+        output.add(s);
+      }
     }
     if (test is BrowserTestCase && test.dynamic.compilerPath != null) {
-      print('\nCompilation command: ${test.dynamic.compilerPath} ' +
-            Strings.join(test.dynamic.compilerArguments, ' '));
+      output.add('');
+      output.add('Compilation command: ${test.dynamic.compilerPath} ' +
+                 Strings.join(test.dynamic.compilerArguments, ' '));
+    }
+    output.add('');
+    output.add('Command line: ${test.commandLine}');
+
+    for (String line in output) {
+      print(line);
+    }
+    _failureSummary.addAll(output);
+  }
+
+  void _printFailureSummary() {
+    for (String line in _failureSummary) {
+      print(line);
     }
-    print('\nCommand line: ${test.commandLine}');
+    print('');
   }
 
   void _printStatus() {
@@ -153,6 +177,7 @@ class ProgressIndicator {
   Date _startTime;
   bool _printTiming;
   List<TestCase> _tests;
+  List<String> _failureSummary;
 }
 
 
@@ -162,7 +187,10 @@ class CompactIndicator extends ProgressIndicator {
 
   void allDone() {
     stdout.write('\n'.charCodes());
+    _printFailureSummary();
     _printTimingInformation();
+    _printProgress();

[Mads Ager (google), 2012/01/16 10:45:00]

Do you really want to print progress here again? I think I would avoid that (it
would duplicate the '[time | percent | pass | fail]' line).

[Bill Hesse, 2012/01/16 11:24:35]

It is nice to have that as the last line of the output.  Otherwise, the user has
to scroll up an unknown amount to find the results - they are really hard to
find.

On 2012/01/16 10:45:00, Mads Ager wrote:

+    print('');
     stdout.close();
     exit(_failedTests > 0 ? 1 : 0);
   }