Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome_frame/metrics_service.cc

Issue 9232071: Upload UMA data using protocol buffers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/metrics/metrics_log_manager.h ('K') | « chrome/common/pref_names.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/metrics_service.cc
diff --git a/chrome_frame/metrics_service.cc b/chrome_frame/metrics_service.cc
index 01e3c50d93cc01737cb353c51a7c8bdff9cdc289..8d362de30d0bcaf7861d69bab45982e4cef56a1c 100644
--- a/chrome_frame/metrics_service.cc
+++ b/chrome_frame/metrics_service.cc
@@ -419,6 +419,8 @@ bool MetricsService::TransmissionPermitted() const {
return user_permits_upload_;
}
+// TODO(isherman): Update this to log to the protobuf server as well...
+// http://crbug.com/109817
bool MetricsService::UploadData() {
DCHECK_EQ(thread_, base::PlatformThread::CurrentId());
@@ -436,12 +438,12 @@ bool MetricsService::UploadData() {
bool ret = true;
- if (log_manager_.staged_log_text().empty()) {
+ if (log_manager_.staged_log_text_xml().empty()) {
NOTREACHED() << "Failed to compress log for transmission.";
ret = false;
} else {
HRESULT hr = ChromeFrameMetricsDataUploader::UploadDataHelper(
- log_manager_.staged_log_text());
+ log_manager_.staged_log_text_xml());
DCHECK(SUCCEEDED(hr));
}
log_manager_.DiscardStagedLog();
« chrome/common/metrics/metrics_log_manager.h ('K') | « chrome/common/pref_names.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698