Upload UMA data using protocol buffers.

chrome/browser/metrics/metrics_log.h

Index: chrome/browser/metrics/metrics_log.h
diff --git a/chrome/browser/metrics/metrics_log.h b/chrome/browser/metrics/metrics_log.h
index a5a3504cc6f51adca77798e2825edae7ade1f2be..5935139a58133d6e8119b08d9ab250e35254c7f8 100644
--- a/chrome/browser/metrics/metrics_log.h
+++ b/chrome/browser/metrics/metrics_log.h
@@ -65,18 +65,25 @@ class MetricsLog : public MetricsLogBase {
   // Record recent delta for critical stability metrics.  We can't wait for a
   // restart to gather these, as that delay biases our observation away from
   // users that run happily for a looooong time.  We send increments with each
-  // uma log upload, just as we send histogram data.
-  void RecordIncrementalStabilityElements();
+  // uma log upload, just as we send histogram data.  Takes the list of
+  // installed plugins as a parameter because that can't be obtained
+  // synchronously from the UI thread.

[jar (doing other things), 2012/02/23 01:59:18]

I'm a bit wary if we can't get this list, then then I'd wonder about the plugin
info ongoing accessibility.... but maybe this is a full blown copy.

Is this a copy, made to avoid thread and lifetime issues?

[Ilya Sherman, 2012/02/24 02:10:06]

Yes, this is a copy (unless I'm reading the MetricsService code wrong -- this is
MetricsService::plugins_).

+  void RecordIncrementalStabilityElements(
+      const std::vector<webkit::WebPluginInfo>& plugin_list);
 
  private:
   FRIEND_TEST_ALL_PREFIXES(MetricsLogTest, ChromeOSStabilityData);
 
   // Writes application stability metrics (as part of the profile log).
   // NOTE: Has the side-effect of clearing those counts.
-  void WriteStabilityElement(PrefService* pref);
+  void WriteStabilityElement(
+      const std::vector<webkit::WebPluginInfo>& plugin_list,
+      PrefService* pref);
 
   // Within stability group, write plugin crash stats.
-  void WritePluginStabilityElements(PrefService* pref);
+  void WritePluginStabilityElements(
+      const std::vector<webkit::WebPluginInfo>& plugin_list,
+      PrefService* pref);
 
   // Within the stability group, write required attributes.
   void WriteRequiredStabilityAttributes(PrefService* pref);