[tools] Add --times option to bisect-builds.py

[tools] Add --times option to bisect-builds.py

R=rsesek@chromium.org,maruel@chromium.org
TEST=script still works, -t/--times works as expected, no stack when (q)uitting.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119558

[Dan Beam, 2012-01-27 19:55:22]

let me know what you think

[M-A Ruel, 2012-01-27 19:58:42]

lgtm with a nit

https://chromiumcodereview.appspot.com/9232057/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://chromiumcodereview.appspot.com/9232057/diff/1/tools/bisect-builds.py#...
tools/bisect-builds.py:524: num_runs = int(opts.times)
It's already a int, no need to cast it.

[Robert Sesek, 2012-01-27 19:58:47]

https://chromiumcodereview.appspot.com/9232057/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://chromiumcodereview.appspot.com/9232057/diff/1/tools/bisect-builds.py#...
tools/bisect-builds.py:297: @param num_runs Number of tiles to run each build
for asking good/bad.
nit: tiles

https://chromiumcodereview.appspot.com/9232057/diff/1/tools/bisect-builds.py#...
tools/bisect-builds.py:429: for f in [_GetDownloadPath(revlist[down_pivot]),
What's this change about?

[Dan Beam, 2012-01-27 22:08:11]

https://chromiumcodereview.appspot.com/9232057/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://chromiumcodereview.appspot.com/9232057/diff/1/tools/bisect-builds.py#...
tools/bisect-builds.py:297: @param num_runs Number of tiles to run each build
for asking good/bad.
On 2012/01/27 19:58:47, rsesek wrote:
> nit: tiles

Done. (have NTP on the brain, lol)

https://chromiumcodereview.appspot.com/9232057/diff/1/tools/bisect-builds.py#...
tools/bisect-builds.py:429: for f in [_GetDownloadPath(revlist[down_pivot]),
On 2012/01/27 19:58:47, rsesek wrote:
> What's this change about?

The script would throw an error when you responded (q)uit as somebody moved this
block and the local variables weren't defined in this scope.

https://chromiumcodereview.appspot.com/9232057/diff/1/tools/bisect-builds.py#...
tools/bisect-builds.py:524: num_runs = int(opts.times)
On 2012/01/27 19:58:42, Marc-Antoine Ruel wrote:
> It's already a int, no need to cast it.

Done.

[Robert Sesek, 2012-01-27 22:37:37]

lgtm

[commit-bot: I haz the power, 2012-01-27 22:39:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/9232057/3002

[commit-bot: I haz the power, 2012-01-28 02:16:57]

Change committed as 119558