Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 9232056: Add Malay as a translation. (Closed)

Created:
8 years, 11 months ago by tony
Modified:
8 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, finnur+watch_chromium.org, pam+watch_chromium.org, jshin+watch_chromium.org, Mattias Nissler (ping if slow)
Visibility:
Public.

Description

Add Malay as a translation. The language code is ms. This adds the necessary files to generate the locale pak file. Translations will arrive later. BUG=111670 TBR=gfeher Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119548

Patch Set 1 #

Patch Set 2 : min logical font #

Patch Set 3 : chrome frame #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -28 lines) Patch
M build/common.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chromium_strings.grd View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/app/policy/policy_templates.grd View 5 chunks +5 lines, -0 lines 0 comments Download
A chrome/app/policy/policy_templates_ms.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/app/resources/generated_resources_ms.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/app/resources/google_chrome_strings_ms.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings.grd View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/app/resources/locale_settings_cros.grd View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/app/resources/locale_settings_linux.grd View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/app/resources/locale_settings_mac.grd View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/app/resources/locale_settings_ms.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_win.grd View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/app/resources/platform_locale_settings/locale_settings_cros_ms.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/app/resources/platform_locale_settings/locale_settings_linux_ms.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/app/resources/platform_locale_settings/locale_settings_mac_ms.xtb View 1 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/app/resources/platform_locale_settings/locale_settings_win_ms.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome_frame/locales/locales.gyp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome_frame/resources/chrome_frame_dialogs.grd View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ui/base/strings/app_locale_settings.grd View 2 chunks +2 lines, -3 lines 0 comments Download
A ui/base/strings/app_locale_settings_ms.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/strings/ui_strings.grd View 2 chunks +2 lines, -4 lines 0 comments Download
A ui/base/strings/ui_strings_ms.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A webkit/glue/resources/webkit_strings_ms.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/webkit_strings.grd View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tony
8 years, 11 months ago (2012-01-27 19:15:05 UTC) #1
tony
Also, I don't know if we need specific platform locale settings for Malay (probably need ...
8 years, 11 months ago (2012-01-27 19:41:18 UTC) #2
jungshik at Google
LGTM I'll follow up with the ICU file update.
8 years, 11 months ago (2012-01-27 19:41:45 UTC) #3
jungshik at Google
On 2012/01/27 19:41:18, tony wrote: > Also, I don't know if we need specific platform ...
8 years, 11 months ago (2012-01-27 19:42:52 UTC) #4
tony
Scott, can I get owners approval for the changes to ui/base/strings?
8 years, 11 months ago (2012-01-27 20:18:15 UTC) #5
sky
LGTM
8 years, 11 months ago (2012-01-27 20:20:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/9232056/3027
8 years, 11 months ago (2012-01-27 21:31:14 UTC) #7
commit-bot: I haz the power
Presubmit check for 9232056-3027 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 11 months ago (2012-01-27 21:31:24 UTC) #8
tony
+gfeher, but I'm going to TBR since this is just an xtb change.
8 years, 11 months ago (2012-01-27 21:39:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/9232056/3027
8 years, 11 months ago (2012-01-27 21:39:50 UTC) #10
commit-bot: I haz the power
Change committed as 119548
8 years, 11 months ago (2012-01-28 00:57:26 UTC) #11
gfeher
8 years, 10 months ago (2012-01-31 19:25:00 UTC) #12
LGTM for chrome/app/policy

Powered by Google App Engine
This is Rietveld 408576698