Issue 9232055: Clean up some code in view_text_utils.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9232055: Clean up some code in view_text_utils.cc. (Closed)

Created:
8 years, 11 months ago by Alexei Svitkine (slow)

Modified:
8 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Clean up some code in view_text_utils.cc. Remove unnecessary |text16| temporary and change the code to not to compute the width of each word twice. BUG=none TEST=Text in about dialog should look the same as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119967

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -12 lines)			Patch
	M	ui/views/view_text_utils.cc	View		3 chunks	+7 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9232055/1

8 years, 10 months ago (2012-01-31 20:22:31 UTC) #3

Change committed as 119967

Expand Messages | Collapse Messages