Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 9232011: sync: Make ProfileSyncService a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: init Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_components_factory_impl.cc
diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc
index b9d4f76af9c223051b0eb30380472f87780bb820..6417d63376c5b1eab377d686d04b52c0e2025b6d 100644
--- a/chrome/browser/sync/profile_sync_components_factory_impl.cc
+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc
@@ -6,12 +6,10 @@
#include "chrome/browser/extensions/app_notification_manager.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/settings/settings_backend.h"
-#include "chrome/browser/defaults.h"
#include "chrome/browser/prefs/pref_model_associator.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search_engines/template_url_service.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
-#include "chrome/browser/signin/signin_manager.h"
#include "chrome/browser/sync/api/syncable_service.h"
#include "chrome/browser/sync/glue/app_data_type_controller.h"
#include "chrome/browser/sync/glue/app_notification_data_type_controller.h"
@@ -89,25 +87,6 @@ ProfileSyncComponentsFactoryImpl::ProfileSyncComponentsFactoryImpl(
command_line_(command_line) {
}
-ProfileSyncService*
- ProfileSyncComponentsFactoryImpl::CreateProfileSyncService() {
- ProfileSyncService::StartBehavior behavior =
- browser_defaults::kSyncAutoStarts ? ProfileSyncService::AUTO_START
- : ProfileSyncService::MANUAL_START;
-
- SigninManager* signin = profile_->GetSigninManager();
-
- // TODO(tim): Currently, AUTO/MANUAL settings refer to the *first* time sync
- // is set up and *not* a browser restart for a manual-start platform (where
- // sync has already been set up, and should be able to start without user
- // intervention). We can get rid of the browser_default eventually, but
- // need to take care that ProfileSyncService doesn't get tripped up between
- // those two cases. Bug 88109.
- ProfileSyncService* pss = new ProfileSyncService(
- this, profile_, signin, behavior);
- return pss;
-}
-
void ProfileSyncComponentsFactoryImpl::RegisterDataTypes(
ProfileSyncService* pss) {
// App sync is enabled by default. Register unless explicitly

Powered by Google App Engine
This is Rietveld 408576698