sync: Make ProfileSyncService a ProfileKeyedService.

chrome/browser/profiles/profile.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class gathers state related to a single user profile.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_H_
 #pragma once
 
@@ skipping 362 matching lines @@
   virtual HostContentSettingsMap* GetHostContentSettingsMap() = 0;
 
   // Returns the user style sheet watcher.
   virtual UserStyleSheetWatcher* GetUserStyleSheetWatcher() = 0;
 
   // Returns the find bar state for this profile.  The find bar state is lazily
   // created the first time that this method is called.
   virtual FindBarState* GetFindBarState() = 0;
 
   // Returns true if this profile has a profile sync service.
-  virtual bool HasProfileSyncService() const = 0;
+  // TODO(tim): Bug 93922 - remove this.
+  virtual bool HasProfileSyncService() = 0;

[Andrew T Wilson (Slow), 2012/01/17 20:25:41]

Why is this no longer const? Not a huge deal since it's going away, but it seems
odd.

[tim (not reviewing), 2012/01/17 23:44:17]

Because it now uses GetServiceForProfile, which takes a non const* to Profile.

 
   // Returns true if the last time this profile was open it was exited cleanly.
   virtual bool DidLastSessionExitCleanly() = 0;
 
   // Returns the BookmarkModel, creating if not yet created.
   virtual BookmarkModel* GetBookmarkModel() = 0;
 
   // Returns the ProtocolHandlerRegistry, creating if not yet created.
   virtual ProtocolHandlerRegistry* GetProtocolHandlerRegistry() = 0;
 
   // Returns the SigninManager, creating if not yet created.
   virtual SigninManager* GetSigninManager() = 0;
 
   // Returns the Gaia Token Service, creating if not yet created.
   virtual TokenService* GetTokenService() = 0;
 
   // Returns the ProfileSyncService, creating if not yet created.
+  // TODO(tim): Bug 93922 - remove this.
   virtual ProfileSyncService* GetProfileSyncService() = 0;
 
   // Return whether 2 profiles are the same. 2 profiles are the same if they
   // represent the same profile. This can happen if there is pointer equality
   // or if one profile is the incognito version of another profile (or vice
   // versa).
   virtual bool IsSameProfile(Profile* profile) = 0;
 
   // Returns the time the profile was started. This is not the time the profile
   // was created, rather it is the time the user started chrome and logged into
@@ skipping 159 matching lines @@
 struct hash<Profile*> {
   std::size_t operator()(Profile* const& p) const {
     return reinterpret_cast<std::size_t>(p);
   }
 };
 
 }  // namespace __gnu_cxx
 #endif
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_H_