Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 9230002: Convert use of int ms to TimeDelta in chrome/service files. (Closed)

Created:
8 years, 11 months ago by Ted Vessenes
Modified:
8 years, 10 months ago
Reviewers:
gene
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Convert use of int ms to TimeDelta in chrome/service files. R=gene@chromium.org BUG=108171 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119952

Patch Set 1 #

Patch Set 2 : Rebase onto master. #

Patch Set 3 : Added conversions in another file owned by ajwong. #

Patch Set 4 : Restrict CL to chrome/service files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M chrome/service/cloud_print/cloud_print_auth.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 1 2 10 chunks +14 lines, -13 lines 0 comments Download
M chrome/service/service_process.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ted Vessenes
8 years, 11 months ago (2012-01-16 00:07:22 UTC) #1
Ted Vessenes
Are you available to take a look at this? I can find other reviewers if ...
8 years, 11 months ago (2012-01-27 15:53:41 UTC) #2
Ted Vessenes
gene@chromium.org: Can you look over this stuff?
8 years, 10 months ago (2012-01-31 16:25:00 UTC) #3
gene
lgtm
8 years, 10 months ago (2012-01-31 18:10:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9230002/7001
8 years, 10 months ago (2012-01-31 18:15:33 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-01-31 20:57:26 UTC) #6
Change committed as 119952

Powered by Google App Engine
This is Rietveld 408576698