Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9228013: Add ash/accelerators/accelerator_filter_unittest.cc (Closed)

Created:
8 years, 11 months ago by Yusuke Sato
Modified:
8 years, 11 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, Jun Mukai
Visibility:
Public.

Description

Add ash/accelerators/accelerator_filter_unittest.cc to prevent a regression like crosbug.com/21842. This CL depends on https://chromiumcodereview.appspot.com/9241007/. BUG=None TEST=ran the unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118619

Patch Set 1 : review #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : review fix #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -0 lines) Patch
A ash/accelerators/accelerator_filter_unittest.cc View 1 2 3 1 chunk +89 lines, -0 lines 0 comments Download
M ash/ash.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yusuke Sato
8 years, 11 months ago (2012-01-18 05:15:41 UTC) #1
mazda
lgtm with a nit https://chromiumcodereview.appspot.com/9228013/diff/5001/ash/accelerators/accelerator_filter_unittest.cc File ash/accelerators/accelerator_filter_unittest.cc (right): https://chromiumcodereview.appspot.com/9228013/diff/5001/ash/accelerators/accelerator_filter_unittest.cc#newcode71 ash/accelerators/accelerator_filter_unittest.cc:71: aura::test::EventGenerator generator_; Please add a ...
8 years, 11 months ago (2012-01-18 05:36:21 UTC) #2
Yusuke Sato
https://chromiumcodereview.appspot.com/9228013/diff/5001/ash/accelerators/accelerator_filter_unittest.cc File ash/accelerators/accelerator_filter_unittest.cc (right): https://chromiumcodereview.appspot.com/9228013/diff/5001/ash/accelerators/accelerator_filter_unittest.cc#newcode71 ash/accelerators/accelerator_filter_unittest.cc:71: aura::test::EventGenerator generator_; On 2012/01/18 05:36:21, mazda wrote: > Please ...
8 years, 11 months ago (2012-01-18 07:59:11 UTC) #3
Yusuke Sato
+ben
8 years, 11 months ago (2012-01-18 07:59:27 UTC) #4
Ben Goodger (Google)
lgtm
8 years, 11 months ago (2012-01-18 18:47:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9228013/11001
8 years, 11 months ago (2012-01-18 22:54:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9228013/15001
8 years, 11 months ago (2012-01-21 12:24:47 UTC) #7
commit-bot: I haz the power
8 years, 11 months ago (2012-01-21 16:15:15 UTC) #8 
Change committed as 118619

Powered by Google App Engine
This is Rietveld 408576698