Issue 9226036: Refactor WebGraphicsContext3DInProcess and TestWebGraphicsContext3D

Issue 9226036: Refactor WebGraphicsContext3DInProcess and TestWebGraphicsContext3D (Closed)

Created:
8 years, 11 months ago by piman

Modified:
8 years, 10 months ago

Reviewers:
Ken Russell (switch to Gerrit), tony

CC:
chromium-reviews, pam+watch_chromium.org, jonathan.backer, Ian Vollick, dhollowa+watch_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor WebGraphicsContext3DInProcess and TestWebGraphicsContext3D This needs https://bugs.webkit.org/show_bug.cgi?id=76593 to land first. This also removes WebKitPlatformSupport::createGraphicsContext3D implementations that are not called any more after the above. BUG=None TEST=chrome with accelerated content, DRT, test_shell_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120431

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, nit #

Patch Set 3 : rebase #

Patch Set 4 : fix windows build #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -175 lines)			Patch
M	content/renderer/render_view_impl.cc	View	1	1 chunk	+7 lines, -11 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.cc	View	1	2 chunks	+6 lines, -28 lines	0 comments	Download
M	ui/gfx/compositor/compositor.cc	View	1 2	1 chunk	+6 lines, -5 lines	0 comments	Download
M	ui/gfx/compositor/test_web_graphics_context_3d.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	ui/gfx/compositor/test_web_graphics_context_3d.cc	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	webkit/gpu/webgraphicscontext3d_in_process_impl.h	View	1 2	3 chunks	+13 lines, -6 lines	0 comments	Download
M	webkit/gpu/webgraphicscontext3d_in_process_impl.cc	View	1 2	8 chunks	+101 lines, -63 lines	0 comments	Download
M	webkit/support/test_webkit_platform_support.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/support/test_webkit_platform_support.cc	View	1 2 3	1 chunk	+10 lines, -24 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	1 2 3	2 chunks	+13 lines, -11 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_webkit_init.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_webkit_init.cc	View	1	1 chunk	+2 lines, -11 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM (mainly just checking style). https://chromiumcodereview.appspot.com/9226036/diff/1/ui/gfx/compositor/test_web_graphics_context_3d.h File ui/gfx/compositor/test_web_graphics_context_3d.h (right): https://chromiumcodereview.appspot.com/9226036/diff/1/ui/gfx/compositor/test_web_graphics_context_3d.h#newcode28 ui/gfx/compositor/test_web_graphics_context_3d.h:28: void initialize(); Nit: Should ...

8 years, 11 months ago (2012-01-21 07:03:24 UTC) #3

piman

The webkit side has landed, still waiting on it to roll in. https://chromiumcodereview.appspot.com/9226036/diff/1/ui/gfx/compositor/test_web_graphics_context_3d.h File ui/gfx/compositor/test_web_graphics_context_3d.h ...

8 years, 10 months ago (2012-01-31 22:14:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9226036/6012

8 years, 10 months ago (2012-02-03 20:30:29 UTC) #5

Change committed as 120431

Expand Messages | Collapse Messages