Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 9226035: Adds TTL argument to HostCache::Set. (Closed)

Created:
8 years, 11 months ago by szym
Modified:
8 years, 11 months ago
Reviewers:
cbentzel, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org, arv (Not doing code reviews), mmenke
Visibility:
Public.

Description

Adds TTL argument to HostCache::Set. Re-lands r118489 but with static initializers removed. BUG=25472, 107880 TEST=net_unittests R=mmenke Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118574

Patch Set 1 #

Total comments: 2

Patch Set 2 : removed the two other static initializers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -135 lines) Patch
M chrome/browser/resources/net_internals/dns_view.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/net_internals/dns_view.js View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/net_internals/dns_view.js View 1 chunk +0 lines, -4 lines 0 comments Download
M net/base/host_cache.h View 4 chunks +6 lines, -17 lines 0 comments Download
M net/base/host_cache.cc View 4 chunks +6 lines, -26 lines 0 comments Download
M net/base/host_cache_unittest.cc View 23 chunks +65 lines, -44 lines 0 comments Download
M net/base/host_resolver_impl.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M net/base/mock_host_resolver.cc View 1 3 chunks +11 lines, -5 lines 0 comments Download
M net/dns/async_host_resolver.cc View 3 chunks +14 lines, -7 lines 0 comments Download
M net/proxy/proxy_resolver_js_bindings.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M net/proxy/proxy_resolver_js_bindings_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
szym
Changed kCacheEntryTTL to kCacheEntryTTLSeconds.
8 years, 11 months ago (2012-01-20 22:34:41 UTC) #1
szym
On 2012/01/20 22:34:41, szym wrote: > Changed kCacheEntryTTL to kCacheEntryTTLSeconds.
8 years, 11 months ago (2012-01-20 22:38:04 UTC) #2
mmenke
LGTM, modulo comments http://codereview.chromium.org/9226035/diff/1/net/base/mock_host_resolver.cc File net/base/mock_host_resolver.cc (right): http://codereview.chromium.org/9226035/diff/1/net/base/mock_host_resolver.cc#newcode28 net/base/mock_host_resolver.cc:28: const base::TimeDelta kCacheEntryTTL = base::TimeDelta::FromMinutes(1); Going ...
8 years, 11 months ago (2012-01-20 22:42:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/9226035/4001
8 years, 11 months ago (2012-01-20 23:03:12 UTC) #4
commit-bot: I haz the power
8 years, 11 months ago (2012-01-21 00:56:30 UTC) #5
Change committed as 118574

Powered by Google App Engine
This is Rietveld 408576698