Checkpoint: android fixes towards compilation of unit_tests.

Checkpoint: android fixes towards compilation of unit_tests.

Dependent on clipboard.h change in https://chromiumcodereview.appspot.com/9264014

BUG=None
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118567

[Mark Mentovai, 2012-01-20 14:20:55]

LGTM

[commit-bot: I haz the power, 2012-01-20 20:02:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrg@chromium.org/9226012/2001

[commit-bot: I haz the power, 2012-01-20 20:02:32]

Presubmit check for 9226012-2001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  chrome/browser/sync/syncable/syncable.cc:2153
    EntryKernel* entry = GetPossibleLastChildForTest(lock, parent_id);

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/profiles/profile.h,chrome/browser/sync/syncable/syncable.cc,content/public/browser/browser_context.h

Presubmit checks took 1.3s to calculate.

[Miranda Callahan, 2012-01-20 20:08:40]

On 2012/01/20 20:02:32, I haz the power (commit-bot) wrote:
> Presubmit check for 9226012-2001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> You might be calling functions intended only for testing from
> production code.  It is OK to ignore this warning if you know what
> you are doing, as the heuristics used to detect the situation are
> not perfect.  The commit queue will not block on this warning.
> Email mailto:joi@chromium.org if you have questions.
>   chrome/browser/sync/syncable/syncable.cc:2153
>     EntryKernel* entry = GetPossibleLastChildForTest(lock, parent_id);
> 
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for:
>
chrome/browser/profiles/profile.h,chrome/browser/sync/syncable/syncable.cc,content/public/browser/browser_context.h
> 
> Presubmit checks took 1.3s to calculate.

LGTM with change discussed in chat.

[John Grabowski, 2012-01-20 20:11:05]

+jam for OWNERS of trivial change in browser_context.h

[John Grabowski, 2012-01-20 20:11:29]

+ mirandac to make sure OWNERS check finds her LGTM for profile.h

[jam, 2012-01-20 20:15:47]

content public lgtm

[commit-bot: I haz the power, 2012-01-20 20:19:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrg@chromium.org/9226012/2002

[commit-bot: I haz the power, 2012-01-20 20:19:51]

Presubmit check for 9226012-2002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  chrome/browser/sync/syncable/syncable.cc:2153
    EntryKernel* entry = GetPossibleLastChildForTest(lock, parent_id);

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for: chrome/browser/sync/syncable/syncable.cc

Presubmit checks took 1.9s to calculate.

[John Grabowski, 2012-01-20 20:24:22]

+ some more OWNERS to approve a simple change to syncable.cc please kthx

[Nicolas Zea, 2012-01-20 22:30:34]

lgtm

[commit-bot: I haz the power, 2012-01-20 22:37:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrg@chromium.org/9226012/2002

[commit-bot: I haz the power, 2012-01-21 00:45:42]

Change committed as 118567