Fix a use-after free in socket pool which can happen after reaching the maxium number of sockets.

Fix a use-after free in socket pool which can happen after reaching the maxium number of sockets.

BUG=109876
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118506

[eroman, 2012-01-20 06:23:47]

Please either mmenke or vandebo review this; whoever feels more qualified ;)

I haven't figured out a unit-test yet, I am hoping to skip it for this check-in
to at least see if it fixes the crashes.

[mmenke, 2012-01-20 12:44:54]

On 2012/01/20 06:23:47, eroman wrote:
> Please either mmenke or vandebo review this; whoever feels more qualified ;)
> 
> I haven't figured out a unit-test yet, I am hoping to skip it for this
check-in
> to at least see if it fixes the crashes.

LGTM

[mmenke, 2012-01-20 15:10:05]

On 2012/01/20 12:44:54, Matt Menke wrote:
> On 2012/01/20 06:23:47, eroman wrote:
> > Please either mmenke or vandebo review this; whoever feels more qualified ;)
> > 
> > I haven't figured out a unit-test yet, I am hoping to skip it for this
> check-in
> > to at least see if it fixes the crashes.
> 
> LGTM

Oh, and I'm happy to write a unit test for this.  I want to familiarize myself a
bit more with the socket pool code, anyways.  If you have some burning desire to
write one yourself, speak up.  Otherwise, I'll just go ahead and do it.

[mmenke, 2012-01-20 16:05:35]

I had assumed this was caused by closing an SSL/SPDY connection to open a
non-SSL/SPDY connection, but we use different groups for them.

So I guess this actually only happens when preconnecting, and NO_IDLE_SOCKETS is
specified.  Another option would be not to close sockets when NO_IDLE_SOCKETS is
indicated.

[commit-bot: I haz the power, 2012-01-20 19:34:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/9226011/1

[eroman, 2012-01-20 19:34:37]

> Oh, and I'm happy to write a unit test for this.

Awesome, thanks!

[commit-bot: I haz the power, 2012-01-20 21:27:18]

Change committed as 118506