chrome/browser/ui/webui/sync_setup_handler2.cc - Issue 9225053: Add a blocking version of the sync promo dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_setup_handler2.cc

Issue 9225053: Add a blocking version of the sync promo dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/sync_setup_handler2.cc

diff --git a/chrome/browser/ui/webui/sync_setup_handler2.cc b/chrome/browser/ui/webui/sync_setup_handler2.cc

index d57a1a5016573fe0de2d0771e495249b3b684a8e..6b24dd377f69513c17ebcf38b1654844f0df6ad2 100644

--- a/chrome/browser/ui/webui/sync_setup_handler2.cc

+++ b/chrome/browser/ui/webui/sync_setup_handler2.cc

@@ -226,7 +226,7 @@ void SyncSetupHandler2::GetStaticLocalizedValues(

bool is_launch_page = web_ui && SyncPromoUI::GetIsLaunchPageForSyncPromoURL(

web_ui->GetWebContents()->GetURL());

- int title_id = is_launch_page ? IDS_SYNC_PROMO_TITLE :

+ int title_id = is_launch_page ? IDS_SYNC_PROMO_TITLE_SHORT :

IDS_SYNC_PROMO_TITLE_EXISTING_USER;

string16 short_product_name(GetStringUTF16(IDS_SHORT_PRODUCT_NAME));

localized_strings->SetString(