Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 9225042: Fix Autofill hang when interacting with large forms (i.e. forms containing many fields). (Closed)

Created:
8 years, 11 months ago by Ilya Sherman
Modified:
8 years, 10 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, GeorgeY, dhollowa+watch_chromium.org, darin-cc_chromium.org, dyu1, brettw-cc_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Fix Autofill hang when interacting with large forms (i.e. forms containing many fields). BUG=111319 TEST=browser_tests --gtest_filter=FormAutofillTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120483

Patch Set 1 #

Patch Set 2 : Re-allow serialization of small forms #

Patch Set 3 : Fix test failure -- don't count hidden fields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -18 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_util.h View 1 3 chunks +10 lines, -3 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_util.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/form_cache.cc View 1 2 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ilya Sherman
Please tick the commit queue checkbox if all looks good. Thanks :)
8 years, 11 months ago (2012-01-28 06:05:20 UTC) #1
dhollowa
lgtm
8 years, 10 months ago (2012-01-30 22:19:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/9225042/1
8 years, 10 months ago (2012-01-30 22:19:52 UTC) #3
commit-bot: I haz the power
Try job failure for 9225042-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 10 months ago (2012-01-30 23:02:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/9225042/1
8 years, 10 months ago (2012-01-30 23:32:42 UTC) #5
commit-bot: I haz the power
Try job failure for 9225042-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 10 months ago (2012-01-31 01:20:05 UTC) #6
Ilya Sherman
Oops, looks like I was a bit too eager with the changes in Patch Set ...
8 years, 10 months ago (2012-02-01 05:55:19 UTC) #7
dhollowa
LG
8 years, 10 months ago (2012-02-03 17:55:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/9225042/9003
8 years, 10 months ago (2012-02-04 06:11:53 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-04 16:49:17 UTC) #10
Change committed as 120483

Powered by Google App Engine
This is Rietveld 408576698