Add NetLog entries to preconnect HttpStreamFactoryImpl::Jobs

Add NetLog entries to preconnect HttpStreamFactoryImpl::Jobs.

R=eroman@chromium.org
BUG=111640
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119543

[eroman, 2012-01-27 20:09:10]

lgtm

http://codereview.chromium.org/9225028/diff/1011/net/http/http_stream_factory...
File net/http/http_stream_factory_impl.cc (right):

http://codereview.chromium.org/9225028/diff/1011/net/http/http_stream_factory...
net/http/http_stream_factory_impl.cc:80: // We use |net_log|'s NetLog instead of
|session_->net_log()| for unit
i don't understand the reference to unit-testing here.. because this constructor
is used by tests?

[mmenke1, 2012-01-27 20:12:49]

http://codereview.chromium.org/9225028/diff/1011/net/http/http_stream_factory...
File net/http/http_stream_factory_impl.cc (right):

http://codereview.chromium.org/9225028/diff/1011/net/http/http_stream_factory...
net/http/http_stream_factory_impl.cc:80: // We use |net_log|'s NetLog instead of
|session_->net_log()| for unit
On 2012/01/27 20:09:10, eroman wrote:
> i don't understand the reference to unit-testing here.. because this
constructor
> is used by tests?

Some of the unit tests pass in a CapturingNetLog when starting requests, so we
need to use the net_log's NetLog.  Otherwise, it arguably would be better and
more consistent to use session_->net_log() here as well as below.

If you find the comment confusing, though, may be best to remove it.

[commit-bot: I haz the power, 2012-01-27 20:34:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/9225028/1014

[commit-bot: I haz the power, 2012-01-27 20:34:53]

Can't apply patch for file net/http/http_stream_factory_impl.cc.
While running patch -p0 --forward --force;
patching file net/http/http_stream_factory_impl.cc
Hunk #1 FAILED at 1.
1 out of 4 hunks FAILED -- saving rejects to file
net/http/http_stream_factory_impl.cc.rej

[commit-bot: I haz the power, 2012-01-27 20:51:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/9225028/7006

[commit-bot: I haz the power, 2012-01-28 00:51:57]

Change committed as 119543