Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: chrome/browser/extensions/extension_tabs_module.h

Issue 9225010: Fix callback for chrome.tabs.update with javascript URLs. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: NULL out web_contents_ if destroyed Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.h
diff --git a/chrome/browser/extensions/extension_tabs_module.h b/chrome/browser/extensions/extension_tabs_module.h
index 944de1c7382c2a8f044a405083464ac82cf22337..726f7fe89e7519141c2e69bb55b9768bc5f07d0a 100644
--- a/chrome/browser/extensions/extension_tabs_module.h
+++ b/chrome/browser/extensions/extension_tabs_module.h
@@ -18,11 +18,13 @@
class BackingStore;
class SkBitmap;
-
+class TabStripModel;
Mihai Parparita -not on Chrome 2012/01/30 16:33:00 Nit: This can be removed now.
jstritar 2012/01/30 16:40:23 Done.
namespace base {
class DictionaryValue;
} // namespace base
-
+namespace content {
+class WebContents;
+} // namespace content
// Windows
class GetWindowFunction : public SyncExtensionFunction {
virtual ~GetWindowFunction() {}
@@ -112,10 +114,13 @@ class UpdateTabFunction : public AsyncExtensionFunction,
private:
virtual ~UpdateTabFunction() {}
virtual bool RunImpl() OVERRIDE;
+ virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE;
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
void OnExecuteCodeFinished(int request_id,
bool success,
const std::string& error);
+ void PopulateResult();
+ content::WebContents* web_contents_;
Mihai Parparita -not on Chrome 2012/01/30 16:33:00 Nit: mind adding an empty line between the methods
jstritar 2012/01/30 16:40:23 Done.
DECLARE_EXTENSION_FUNCTION_NAME("tabs.update")
};
class MoveTabsFunction : public SyncExtensionFunction {
« no previous file with comments | « chrome/browser/extensions/extension_javascript_url_apitest.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698