chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h - Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('j') | content/browser/tab_contents/render_view_host_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

===================================================================

--- chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h (revision 117871)

+++ chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h (working copy)

@@ -20,7 +20,6 @@

CoreChromeOSOptionsHandler();

virtual ~CoreChromeOSOptionsHandler();

- protected:

// ::CoreOptionsHandler overrides

virtual void Initialize() OVERRIDE;

virtual base::Value* FetchPref(const std::string& pref_name) OVERRIDE;

@@ -30,6 +29,7 @@

const std::string& metric) OVERRIDE;

virtual void StopObservingPref(const std::string& path) OVERRIDE;

+ protected:

// content::NotificationObserver implementation.

virtual void Observe(int type,

const content::NotificationSource& source,