chrome/browser/ui/webui/feedback_ui.cc - Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/feedback_ui.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/feedback_ui.h ('k') | chrome/browser/ui/webui/flags_ui.h » ('j') | content/browser/tab_contents/render_view_host_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/feedback_ui.cc

===================================================================

--- chrome/browser/ui/webui/feedback_ui.cc (revision 117871)

+++ chrome/browser/ui/webui/feedback_ui.cc (working copy)

@@ -26,6 +26,7 @@

#include "chrome/browser/ui/window_snapshot/window_snapshot.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/url_constants.h"

+#include "content/browser/webui/web_ui.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/navigation_controller.h"

#include "content/public/browser/navigation_entry.h"

@@ -529,9 +530,10 @@

// FeedbackUI

////////////////////////////////////////////////////////////////////////////////

-FeedbackUI::FeedbackUI(WebContents* tab) : HtmlDialogUI(tab) {

+FeedbackUI::FeedbackUI(WebUI* web_ui) : HtmlDialogUI(web_ui) {

+ WebContents* tab = web_ui->web_contents();

FeedbackHandler* handler = new FeedbackHandler(tab);

- AddMessageHandler(handler);

+ web_ui->AddMessageHandler(handler);

// The handler's init will determine whether we show the error html page.

ChromeWebUIDataSource* html_source =