Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership...

chrome/browser/ui/webui/web_ui_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "chrome/browser/ui/webui/web_ui_browsertest.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 250 matching lines @@
     SendResponse(request_id, response);
   }
 
   std::string GetMimeType(const std::string& path) const OVERRIDE {
     return "text/html";
   }
 
   DISALLOW_COPY_AND_ASSIGN(MockWebUIDataSource);
 };
 
-// WebUI to attach the DataSource for the dummy URL.
-class MockWebUI : public WebUI {
- public:
-  explicit MockWebUI(WebContents* contents, WebUIController* controller)
-    : WebUI(contents, controller) {
-    Profile* profile =
-        Profile::FromBrowserContext(contents->GetBrowserContext());
-    profile->GetChromeURLDataManager()->AddDataSource(
-        new MockWebUIDataSource());
-  }
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(MockWebUI);
-};
-
-// WebUIProvider to allow injection of our WebUI classes for the dummy URL when
+// WebUIProvider to allow attaching the DataSource for the dummy URL when
 // testing.
 class MockWebUIProvider : public TestChromeWebUIFactory::WebUIProvider {
  public:
   MockWebUIProvider() {}
 
   // Returns a new WebUI
-  WebUI* NewWebUI(WebContents* web_contents, const GURL& url) OVERRIDE {
-    static content::WebUIController temp_controller;
-    return new MockWebUI(web_contents, &temp_controller);
+  WebUIController* NewWebUI(WebUI* web_ui, const GURL& url) OVERRIDE {
+    WebUIController* controller = new content::WebUIController(web_ui);
+    Profile* profile = Profile::FromBrowserContext(
+        web_ui->web_contents()->GetBrowserContext());
+    profile->GetChromeURLDataManager()->AddDataSource(
+        new MockWebUIDataSource());
+    return controller;
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MockWebUIProvider);
 };
 
 base::LazyInstance<MockWebUIProvider> mock_provider_ =
     LAZY_INSTANCE_INITIALIZER;
 
 }  // namespace
@@ skipping 389 matching lines @@
 // testDone directly and expect pass result.
 IN_PROC_BROWSER_TEST_F(WebUIBrowserAsyncTest, TestTestDoneEarlyPassesAsync) {
   ASSERT_TRUE(RunJavascriptAsyncTest("testDone"));
 }
 
 // Test that calling testDone during RunJavascriptTest still completes when
 // waiting for async result.
 IN_PROC_BROWSER_TEST_F(WebUIBrowserAsyncTest, TestTestDoneEarlyPasses) {
   ASSERT_TRUE(RunJavascriptTest("testDone"));
 }