Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Side by Side Diff: chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc

Issue 9224002: Make WebUI objects not derive from WebUI. WebUI objects own the controller. This is the ownership... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head to clear linux_chromeos browsertest failures Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/sim_unlock_ui.h" 5 #include "chrome/browser/ui/webui/chromeos/sim_unlock_ui.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/memory/weak_ptr.h" 12 #include "base/memory/weak_ptr.h"
13 #include "base/message_loop.h" 13 #include "base/message_loop.h"
14 #include "base/string_piece.h" 14 #include "base/string_piece.h"
15 #include "base/values.h" 15 #include "base/values.h"
16 #include "chrome/browser/chromeos/cros/cros_library.h" 16 #include "chrome/browser/chromeos/cros/cros_library.h"
17 #include "chrome/browser/chromeos/cros/network_library.h" 17 #include "chrome/browser/chromeos/cros/network_library.h"
18 #include "chrome/browser/chromeos/sim_dialog_delegate.h" 18 #include "chrome/browser/chromeos/sim_dialog_delegate.h"
19 #include "chrome/browser/profiles/profile.h" 19 #include "chrome/browser/profiles/profile.h"
20 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 20 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
21 #include "chrome/common/chrome_notification_types.h" 21 #include "chrome/common/chrome_notification_types.h"
22 #include "chrome/common/jstemplate_builder.h" 22 #include "chrome/common/jstemplate_builder.h"
23 #include "chrome/common/url_constants.h" 23 #include "chrome/common/url_constants.h"
24 #include "content/browser/webui/web_ui.h"
24 #include "content/public/browser/browser_thread.h" 25 #include "content/public/browser/browser_thread.h"
25 #include "content/public/browser/notification_service.h" 26 #include "content/public/browser/notification_service.h"
26 #include "content/public/browser/web_contents.h" 27 #include "content/public/browser/web_contents.h"
27 #include "content/public/browser/web_ui_message_handler.h" 28 #include "content/public/browser/web_ui_message_handler.h"
28 #include "grit/browser_resources.h" 29 #include "grit/browser_resources.h"
29 #include "grit/generated_resources.h" 30 #include "grit/generated_resources.h"
30 #include "ui/base/l10n/l10n_util.h" 31 #include "ui/base/l10n/l10n_util.h"
31 #include "ui/base/resource/resource_bundle.h" 32 #include "ui/base/resource/resource_bundle.h"
32 33
33 using content::BrowserThread; 34 using content::BrowserThread;
(...skipping 621 matching lines...) Expand 10 before | Expand all | Expand 10 after
655 sim_dict.SetInteger(kState, state_); 656 sim_dict.SetInteger(kState, state_);
656 if (!error_msg.empty()) 657 if (!error_msg.empty())
657 sim_dict.SetString(kError, error_msg); 658 sim_dict.SetString(kError, error_msg);
658 else 659 else
659 sim_dict.SetString(kError, kErrorOk); 660 sim_dict.SetString(kError, kErrorOk);
660 web_ui()->CallJavascriptFunction(kJsApiSimStatusChanged, sim_dict); 661 web_ui()->CallJavascriptFunction(kJsApiSimStatusChanged, sim_dict);
661 } 662 }
662 663
663 // SimUnlockUI ----------------------------------------------------------------- 664 // SimUnlockUI -----------------------------------------------------------------
664 665
665 SimUnlockUI::SimUnlockUI(WebContents* contents) : WebUI(contents, this) { 666 SimUnlockUI::SimUnlockUI(WebUI* web_ui) : WebUIController(web_ui) {
666 SimUnlockHandler* handler = new SimUnlockHandler(); 667 SimUnlockHandler* handler = new SimUnlockHandler();
667 AddMessageHandler(handler); 668 web_ui->AddMessageHandler(handler);
668 SimUnlockUIHTMLSource* html_source = new SimUnlockUIHTMLSource(); 669 SimUnlockUIHTMLSource* html_source = new SimUnlockUIHTMLSource();
669 670
670 // Set up the chrome://sim-unlock/ source. 671 // Set up the chrome://sim-unlock/ source.
671 Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext()); 672 Profile* profile = Profile::FromBrowserContext(
673 web_ui->web_contents()->GetBrowserContext());
672 profile->GetChromeURLDataManager()->AddDataSource(html_source); 674 profile->GetChromeURLDataManager()->AddDataSource(html_source);
673 } 675 }
674 676
675 } // namespace chromeos 677 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698