Fixes issue with accelerators when a menu is open

ash/ash.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/chrome',
   },
 
@@ skipping 20 matching lines @@
       ],
       'defines': [
         'ASH_IMPLEMENTATION',
       ],
       'sources': [
         # All .cc, .h under ash, except unittests
         'accelerators/accelerator_controller.cc',
         'accelerators/accelerator_controller.h',
         'accelerators/accelerator_filter.cc',
         'accelerators/accelerator_filter.h',
+        'accelerators/accelerator_handler.cc',
+        'accelerators/accelerator_handler.h',
+        'accelerators/accelerator_handler_linux.cc',
         'app_list/app_list.cc',
         'app_list/app_list.h',
         'app_list/app_list_groups_view.cc',
         'app_list/app_list_groups_view.h',
         'app_list/app_list_item_group_model.cc',
         'app_list/app_list_item_group_model.h',
         'app_list/app_list_item_group_view.cc',
         'app_list/app_list_item_group_view.h',
         'app_list/app_list_item_model.cc',
         'app_list/app_list_item_model.h',
@@ skipping 118 matching lines @@
         'wm/window_util.cc',
         'wm/window_util.h',
         'wm/workspace_controller.cc',
         'wm/workspace_controller.h',
         'wm/workspace/workspace.cc',
         'wm/workspace/workspace.h',
         'wm/workspace/workspace_manager.cc',
         'wm/workspace/workspace_manager.h',
         'wm/workspace/workspace_observer.h',
       ],
+      'conditions' : [
+        ['OS=="win"', {
+          'sources/': [
+            ['exclude', '_linux\\.cc$'],
+          ],
+        }],
+        ['OS=="mac"', {
+          'sources/': [
+            ['exclude', '_linux\\.cc$'],
+          ],
+        }]

[oshima, 2012/01/23 18:06:39]

did you need this? I thought _linux.cc is included only on linux.

[pkotwicz, 2012/01/23 19:33:02]

I think it is necessary. I believe gyp files for major targets have similar
logic which is why _linux.cc ends up being included only on linux. Please
correct me if I am wrong

[oshima, 2012/01/23 21:40:52]

http://code.google.com/codesearch#OAMlx_jo-ck/src/build/common.gypi&exact_pac...

common.gypi does exclude _linux for non linux, although we may be overriding it
somewhere. Can you find where?

+      ],
     },
     {
       'target_name': 'aura_shell_unittests',
       'type': 'executable',
       'dependencies': [
         '../base/base.gyp:base',
         '../base/base.gyp:test_support_base',
         '../chrome/chrome_resources.gyp:packed_resources',
         '../build/temp_gyp/googleurl.gyp:googleurl',
         '../skia/skia.gyp:skia',
@@ skipping 129 matching lines @@
             'shell/cocoa/app-Info.plist',
           ],
           'xcode_settings': {
             'INFOPLIST_FILE': 'shell/cocoa/app-Info.plist',
           },
         }],
       ],
     },
   ],
 }