Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: ui/views/controls/menu/menu_controller.cc

Issue 9224001: Fixes issue with accelerators when a menu is open (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes as requested Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« ash/accelerators/accelerator_dispatcher_win.cc ('K') | « ash/ash.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/controls/menu/menu_controller.h" 5 #include "ui/views/controls/menu/menu_controller.h"
6 6
7 #include "base/i18n/case_conversion.h" 7 #include "base/i18n/case_conversion.h"
8 #include "base/i18n/rtl.h" 8 #include "base/i18n/rtl.h"
9 #include "base/time.h" 9 #include "base/time.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
11 #include "ui/base/dragdrop/os_exchange_data.h" 11 #include "ui/base/dragdrop/os_exchange_data.h"
12 #include "ui/base/events.h" 12 #include "ui/base/events.h"
13 #include "ui/base/keycodes/keyboard_codes.h" 13 #include "ui/base/keycodes/keyboard_codes.h"
14 #include "ui/base/l10n/l10n_util.h" 14 #include "ui/base/l10n/l10n_util.h"
15 #include "ui/gfx/canvas_skia.h" 15 #include "ui/gfx/canvas_skia.h"
16 #include "ui/gfx/screen.h" 16 #include "ui/gfx/screen.h"
17 #include "ui/views/controls/button/menu_button.h" 17 #include "ui/views/controls/button/menu_button.h"
18 #include "ui/views/controls/menu/menu_controller_delegate.h" 18 #include "ui/views/controls/menu/menu_controller_delegate.h"
19 #include "ui/views/controls/menu/menu_scroll_view_container.h" 19 #include "ui/views/controls/menu/menu_scroll_view_container.h"
20 #include "ui/views/controls/menu/submenu_view.h" 20 #include "ui/views/controls/menu/submenu_view.h"
21 #include "ui/views/drag_utils.h" 21 #include "ui/views/drag_utils.h"
22 #include "ui/views/view_constants.h" 22 #include "ui/views/view_constants.h"
23 #include "ui/views/views_delegate.h" 23 #include "ui/views/views_delegate.h"
24 #include "ui/views/widget/root_view.h" 24 #include "ui/views/widget/root_view.h"
25 #include "ui/views/widget/widget.h" 25 #include "ui/views/widget/widget.h"
26 26
27 #if defined(USE_AURA) 27 #if defined(USE_AURA)
28 #include "ash/accelerators/accelerator_dispatcher.h"
28 #include "ui/aura/root_window.h" 29 #include "ui/aura/root_window.h"
29 #elif defined(TOOLKIT_USES_GTK) 30 #elif defined(TOOLKIT_USES_GTK)
30 #include "ui/base/keycodes/keyboard_code_conversion_gtk.h" 31 #include "ui/base/keycodes/keyboard_code_conversion_gtk.h"
31 #endif 32 #endif
32 33
33 using base::Time; 34 using base::Time;
34 using base::TimeDelta; 35 using base::TimeDelta;
35 using ui::OSExchangeData; 36 using ui::OSExchangeData;
36 37
37 // Period of the scroll timer (in milliseconds). 38 // Period of the scroll timer (in milliseconds).
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 if (ViewsDelegate::views_delegate) 312 if (ViewsDelegate::views_delegate)
312 ViewsDelegate::views_delegate->AddRef(); 313 ViewsDelegate::views_delegate->AddRef();
313 314
314 // We need to turn on nestable tasks as in some situations (pressing alt-f for 315 // We need to turn on nestable tasks as in some situations (pressing alt-f for
315 // one) the menus are run from a task. If we don't do this and are invoked 316 // one) the menus are run from a task. If we don't do this and are invoked
316 // from a task none of the tasks we schedule are processed and the menu 317 // from a task none of the tasks we schedule are processed and the menu
317 // appears totally broken. 318 // appears totally broken.
318 MessageLoopForUI* loop = MessageLoopForUI::current(); 319 MessageLoopForUI* loop = MessageLoopForUI::current();
319 bool did_allow_task_nesting = loop->NestableTasksAllowed(); 320 bool did_allow_task_nesting = loop->NestableTasksAllowed();
320 loop->SetNestableTasksAllowed(true); 321 loop->SetNestableTasksAllowed(true);
322 #if defined(USE_AURA)
323 ash::AcceleratorDispatcher dispatcher(this);
324 loop->RunWithDispatcher(&dispatcher);
325 #else
321 loop->RunWithDispatcher(this); 326 loop->RunWithDispatcher(this);
327 #endif
322 loop->SetNestableTasksAllowed(did_allow_task_nesting); 328 loop->SetNestableTasksAllowed(did_allow_task_nesting);
323 329
324 if (ViewsDelegate::views_delegate) 330 if (ViewsDelegate::views_delegate)
325 ViewsDelegate::views_delegate->ReleaseRef(); 331 ViewsDelegate::views_delegate->ReleaseRef();
326 332
327 // Close any open menus. 333 // Close any open menus.
328 SetSelection(NULL, SELECTION_UPDATE_IMMEDIATELY | SELECTION_EXIT); 334 SetSelection(NULL, SELECTION_UPDATE_IMMEDIATELY | SELECTION_EXIT);
329 335
330 if (nested_menu) { 336 if (nested_menu) {
331 DCHECK(!menu_stack_.empty()); 337 DCHECK(!menu_stack_.empty());
(...skipping 1685 matching lines...) Expand 10 before | Expand all | Expand 10 after
2017 (!pending_state_.item->HasSubmenu() || 2023 (!pending_state_.item->HasSubmenu() ||
2018 !pending_state_.item->GetSubmenu()->IsShowing())) { 2024 !pending_state_.item->GetSubmenu()->IsShowing())) {
2019 // On exit if the user hasn't selected an item with a submenu, move the 2025 // On exit if the user hasn't selected an item with a submenu, move the
2020 // selection back to the parent menu item. 2026 // selection back to the parent menu item.
2021 SetSelection(pending_state_.item->GetParentMenuItem(), 2027 SetSelection(pending_state_.item->GetParentMenuItem(),
2022 SELECTION_OPEN_SUBMENU); 2028 SELECTION_OPEN_SUBMENU);
2023 } 2029 }
2024 } 2030 }
2025 2031
2026 } // namespace views 2032 } // namespace views
OLDNEW
« ash/accelerators/accelerator_dispatcher_win.cc ('K') | « ash/ash.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698