Added net logging to BaseFile.

chrome/browser/resources/net_internals/source_entry.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var SourceEntry = (function() {
   'use strict';
 
   /**
    * A SourceEntry gathers all log entries with the same source.
    *
@@ skipping 114 matching lines @@
                   parent.getDescription().length > 0) {
                 this.description_ += ' [' + parent.getDescription() + ']';
               }
             }
           }
           break;
         case LogSourceType.ASYNC_HOST_RESOLVER_REQUEST:
         case LogSourceType.DNS_TRANSACTION:
           this.description_ = e.params.hostname;
           break;
+        case LogSourceType.DOWNLOAD:
+          switch (e.type) {
+            case LogEventType.DOWNLOAD_FILE_RENAMED:
+              this.description_ = e.params.new_filename;
+              break;
+            case LogEventType.DOWNLOAD_FILE_OPENED:
+              this.description_ = e.params.file_name;
+              break;
+          }
+          break;
         case LogSourceType.FILESTREAM:
           this.description_ = e.params.file_name;
           break;
       }
 
       if (this.description_ == undefined)
         this.description_ = '';
     },
 
     /**
@@ skipping 12 matching lines @@
      * TYPE_SOCKET_STREAM_CONNECT.
      */
     getStartEntry_: function() {
       if (this.entries_.length < 1)
         return undefined;
       if (this.entries_[0].source.type == LogSourceType.FILESTREAM) {
         var e = this.findLogEntryByType_(LogEventType.FILE_STREAM_OPEN);
         if (e != undefined)
           return e;
       }
+      if (this.entries_[0].source.type == LogSourceType.DOWNLOAD) {
+        // If any rename occurred, use the last name
+        e = this.findLastLogEntryByType_(LogEventType.DOWNLOAD_FILE_RENAMED);
+        if (e != undefined)
+          return e;
+        // Otherwise, if the file was opened, use that name
+        e = this.findLogEntryByType_(LogEventType.DOWNLOAD_FILE_OPENED);
+        if (e != undefined)
+          return e;
+      }
       if (this.entries_.length >= 2) {
         if (this.entries_[0].type == LogEventType.REQUEST_ALIVE ||
             this.entries_[0].type == LogEventType.SOCKET_POOL_CONNECT_JOB ||
             this.entries_[1].type == LogEventType.UDP_CONNECT) {
           return this.entries_[1];
         }
       }
       return this.entries_[0];
     },
 
     /**
      * Returns the first entry with the specified type, or undefined if not
      * found.
      */
     findLogEntryByType_: function(type) {
       for (var i = 0; i < this.entries_.length; ++i) {
         if (this.entries_[i].type == type) {
           return this.entries_[i];
         }
       }
       return undefined;
     },
 
+    /**
+     * Returns the last entry with the specified type, or undefined if not
+     * found.
+     */
+    findLastLogEntryByType_: function(type) {
+      for (var i = this.entries_.length - 1; i >= 0; --i) {
+        if (this.entries_[i].type == type) {
+          if ((this.entries_[i].phase != LogEventPhase.PHASE_END) &&
+              (this.entries_[i].phase != LogEventPhase.PHASE_FINISH)) {

[mmenke1, 2012/02/03 18:32:32]

Think checking for PHASE_BEGIN makes the most sense.  Also, just to make the
function name correct, I'd suggest either taking in a phase as an argument (And
in findLogEntryByType as well), or making the function name clearer.

[ahendrickson, 2012/02/04 05:27:14]

Done.

+            return this.entries_[i];
+          }
+        }
+      }
+      return undefined;
+    },
+
     getLogEntries: function() {
       return this.entries_;
     },
 
     getSourceTypeString: function() {
       return getKeyWithValue(LogSourceType, this.entries_[0].source.type);
     },
 
     getSourceType: function() {
       return this.entries_[0].source.type;
@@ skipping 47 matching lines @@
      * Prints descriptive text about |entries_| to a new node added to the end
      * of |parent|.
      */
     printAsText: function(parent) {
       printLogEntriesAsText(this.entries_, parent);
     }
   };
 
   return SourceEntry;
 })();