Fix try/finally clause when uploading an issue

gcl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
@@ skipping 839 matching lines @@
   upload_arg.append("--server=%s" % change_info.rietveld)
 
   reviewers = change_info.reviewers or output.reviewers
   if (reviewers and
       not any(arg.startswith('-r') or arg.startswith('--reviewer') for
               arg in args)):
     upload_arg.append('--reviewers=%s' % ','.join(reviewers))
 
   upload_arg.extend(args)
 
-  desc_file = ""
-  if change_info.issue:  # Uploading a new patchset.
-    found_message = False
-    for arg in args:
-      if arg.startswith("--message") or arg.startswith("-m"):
-        found_message = True
-        break
+  desc_file = None
+  try:
+    if change_info.issue:  # Uploading a new patchset.
+      found_message = False
+      for arg in args:
+        if arg.startswith("--message") or arg.startswith("-m"):
+          found_message = True
+          break
 
-    if not found_message:
-      upload_arg.append("--message=''")
+      if not found_message:
+        upload_arg.append("--message=''")
 
-    upload_arg.append("--issue=%d" % change_info.issue)
-  else: # First time we upload.
-    handle, desc_file = tempfile.mkstemp(text=True)
-    os.write(handle, change_info.description)
-    os.close(handle)
+      upload_arg.append("--issue=%d" % change_info.issue)
+    else: # First time we upload.
+      handle, desc_file = tempfile.mkstemp(text=True)
+      os.write(handle, change_info.description)
+      os.close(handle)
 
-    # Watchlist processing -- CC people interested in this changeset
-    # http://dev.chromium.org/developers/contributing-code/watchlists
-    if not no_watchlists:
-      import watchlists
-      watchlist = watchlists.Watchlists(change_info.GetLocalRoot())
-      watchers = watchlist.GetWatchersForPaths(change_info.GetFileNames())
+      # Watchlist processing -- CC people interested in this changeset
+      # http://dev.chromium.org/developers/contributing-code/watchlists
+      if not no_watchlists:
+        import watchlists
+        watchlist = watchlists.Watchlists(change_info.GetLocalRoot())
+        watchers = watchlist.GetWatchersForPaths(change_info.GetFileNames())
 
-    cc_list = GetCodeReviewSetting("CC_LIST")
-    if not no_watchlists and watchers:
-      # Filter out all empty elements and join by ','
-      cc_list = ','.join(filter(None, [cc_list] + watchers))
-    if cc_list:
-      upload_arg.append("--cc=" + cc_list)
-    upload_arg.append("--description_file=" + desc_file + "")
-    if change_info.subject:
-      upload_arg.append("--message=" + change_info.subject)
+      cc_list = GetCodeReviewSetting("CC_LIST")
+      if not no_watchlists and watchers:
+        # Filter out all empty elements and join by ','
+        cc_list = ','.join(filter(None, [cc_list] + watchers))
+      if cc_list:
+        upload_arg.append("--cc=" + cc_list)
+      upload_arg.append("--description_file=%s" % desc_file)
+      if change_info.subject:
+        upload_arg.append("--message=" + change_info.subject)
 
-    if GetCodeReviewSetting("PRIVATE") == "True":
-      upload_arg.append("--private")
+      if GetCodeReviewSetting("PRIVATE") == "True":
+        upload_arg.append("--private")
 
-  # If we have a lot of files with long paths, then we won't be able to fit
-  # the command to "svn diff".  Instead, we generate the diff manually for
-  # each file and concatenate them before passing it to upload.py.
-  if change_info.patch is None:
-    change_info.patch = GenerateDiff(change_info.GetFileNames())
+    # If we have a lot of files with long paths, then we won't be able to fit
+    # the command to "svn diff".  Instead, we generate the diff manually for
+    # each file and concatenate them before passing it to upload.py.
+    if change_info.patch is None:
+      change_info.patch = GenerateDiff(change_info.GetFileNames())
 
-  # Change the current working directory before calling upload.py so that it
-  # shows the correct base.
-  previous_cwd = os.getcwd()
-  os.chdir(change_info.GetLocalRoot())
-  try:
+    # Change the current working directory before calling upload.py so that it
+    # shows the correct base.
+    previous_cwd = os.getcwd()
+    os.chdir(change_info.GetLocalRoot())
     try:
-      issue, patchset = upload.RealMain(upload_arg, change_info.patch)
-    except KeyboardInterrupt:
-      sys.exit(1)
-    if issue and patchset:
-      change_info.issue = int(issue)
-      change_info.patchset = int(patchset)
-      change_info.Save()
-
+      try:
+        issue, patchset = upload.RealMain(upload_arg, change_info.patch)
+      except KeyboardInterrupt:
+        sys.exit(1)
+      if issue and patchset:
+        change_info.issue = int(issue)
+        change_info.patchset = int(patchset)
+        change_info.Save()
+      change_info.PrimeLint()
+    finally:
+      os.chdir(previous_cwd)
+  finally:
     if desc_file:
       os.remove(desc_file)
-    change_info.PrimeLint()
-  finally:
-    os.chdir(previous_cwd)
   print "*** Upload does not submit a try; use gcl try to submit a try. ***"
   return 0
 
 
 @need_change_and_args
 @attrs(usage='[--upload]')
 def CMDpresubmit(change_info, args):
   """Runs presubmit checks on the change.
 
   The actual presubmit code is implemented in presubmit_support.py and looks
@@ skipping 529 matching lines @@
       raise
     print >> sys.stderr, (
         'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
         'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
     return 1
 
 
 if __name__ == "__main__":
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))