chrome/browser/extensions/extension_service.cc - Issue 9222013: Prevent unnecessary prompts when unpacked extensions use chrome.permissions.request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 9222013: Prevent unnecessary prompts when unpacked extensions use chrome.permissions.request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/permissions/permissions_apitest.cc ('K') | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/permissions_updater.cc » ('j') | chrome/common/extensions/extension.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 7891b8364bbd2f3d4400a05370075e2cde2b5761..9d8695158d41217f3e56210470c0c773721532b5 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -2116,7 +2116,7 @@ void ExtensionService::InitializePermissions(const Extension* extension) {

// We only need to compare the granted permissions to the current permissions

// if the extension is not allowed to silently increase its permissions.

- if (!extension->CanSilentlyIncreasePermissions()) {

+ if (!extension->CanSilentlyIncreasePermissionsDuringInstall()) {

// Add all the recognized permissions if the granted permissions list

// hasn't been initialized yet.

scoped_refptr<ExtensionPermissionSet> granted_permissions =