chrome/test/data/extensions/api_test/permissions/optional_deny/background.js - Issue 9222013: Prevent unnecessary prompts when unpacked extensions use chrome.permissions.request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/permissions/optional_deny/background.js

Issue 9222013: Prevent unnecessary prompts when unpacked extensions use chrome.permissions.request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reword comment Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/permissions/optional/background.js ('k') | chrome/test/data/extensions/api_test/permissions/optional_deny/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/permissions/optional_deny/background.js

diff --git a/chrome/test/data/extensions/api_test/permissions/optional_deny/background.js b/chrome/test/data/extensions/api_test/permissions/optional_deny/background.js

index 8b2a6db6183a97dfbfd61fa9349a84137e040ed3..2f55089331394ea5c339dfec8e663bf492b66cfa 100644

--- a/chrome/test/data/extensions/api_test/permissions/optional_deny/background.js

+++ b/chrome/test/data/extensions/api_test/permissions/optional_deny/background.js

@@ -60,6 +60,15 @@ chrome.test.getConfig(function(config) {

assertFalse(result);

}));

+ },

+ function noPromptForActivePermissions() {

+ // We shouldn't prompt if the extension already has the permissions.

+ chrome.permissions.request(

+ {permissions: ["management"]},

+ pass(function(granted) {

+ assertTrue(granted);

+ }));

}

]);

});