Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7908)

Unified Diff: chrome/common/extensions/extension.h

Issue 9222013: Prevent unnecessary prompts when unpacked extensions use chrome.permissions.request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reword comment Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/unpacked_installer.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 97b7930427b0a6fbe46d2cb351f3098dd73a2841..a2ee6e20bbb7f7a85ba9f190fd0de8a1fd5427d7 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -396,11 +396,13 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
const URLPatternSet& GetEffectiveHostPermissions() const;
// Returns true if the extension can silently increase its permission level.
- // Extensions that can silently increase permissions are installed through
- // mechanisms that are implicitly trusted.
+ // Users must approve permissions for unpacked and packed extensions in the
+ // following situations:
+ // - when installing or upgrading packed extensions
+ // - when installing unpacked extensions that have NPAPI plugins
+ // - when either type of extension requests optional permissions
bool CanSilentlyIncreasePermissions() const;
-
// Whether the extension has access to the given URL.
bool HasHostPermission(const GURL& url) const;
« no previous file with comments | « chrome/browser/extensions/unpacked_installer.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698