chrome/browser/extensions/crx_installer.cc - Issue 9222013: Prevent unnecessary prompts when unpacked extensions use chrome.permissions.request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 9222013: Prevent unnecessary prompts when unpacked extensions use chrome.permissions.request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reword comment Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_apitest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/crx_installer.cc

diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc

index 3731187c99decabd15259e5b39e6a5ff07a00727..41b97602f92bb4dbb76244c9b3d403e3f3cda27a 100644

--- a/chrome/browser/extensions/crx_installer.cc

+++ b/chrome/browser/extensions/crx_installer.cc

@@ -583,9 +583,8 @@ void CrxInstaller::ReportSuccessFromUIThread() {

// We update the extension's granted permissions if the user already approved

// the install (client_ is non NULL), or we are allowed to install this

- // silently. We only track granted permissions for INTERNAL extensions.

- if ((client_ || allow_silent_install_) &&

- extension_->location() == Extension::INTERNAL) {

+ // silently.

+ if (client_ || allow_silent_install_) {

PermissionsUpdater perms_updater(profile());

perms_updater.GrantActivePermissions(extension_);

}