Prevent unnecessary prompts when unpacked extensions use chrome.permissions.request.

chrome/common/extensions/extension.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 378 matching lines @@
                         string16* error,
                         ExtensionAPIPermissionSet* api_permissions,
                         URLPatternSet* host_permissions);
 
   bool HasAPIPermission(ExtensionAPIPermission::ID permission) const;
   bool HasAPIPermission(const std::string& function_name) const;
 
   const URLPatternSet& GetEffectiveHostPermissions() const;
 
   // Returns true if the extension can silently increase its permission level.
-  // Extensions that can silently increase permissions are installed through
-  // mechanisms that are implicitly trusted.
-  bool CanSilentlyIncreasePermissions() const;
-
+  // We distinguish between install/upgrade and runtime to simplify extension
+  // development. We prompt at install time for packaged extensions and unpacked

[Yoyo Zhou, 2012/01/24 19:42:23]

packaged -> packed

+  // extensions that contain plugins. We prompt for both types of extensions
+  // when they request permissions with the permissions API.
+  bool CanSilentlyIncreasePermissionsDuringInstall() const;
+  bool CanSilentlyIncreasePermissionsWhileRunning() const;

[jstritar, 2012/01/24 17:54:44]

Are these methods confusing?

[Yoyo Zhou, 2012/01/24 19:42:23]

Maybe "upgrade" instead of "install"? (Does it make sense to increase something
during the first install?)

[jstritar, 2012/01/25 17:34:18]

I ended up going back to just one CanSilentlyIncreasePermissions method.

 
   // Whether the extension has access to the given URL.
   bool HasHostPermission(const GURL& url) const;
 
   // Whether the extension has effective access to all hosts. This is true if
   // there is a content script that matches all hosts, if there is a host
   // permission grants access to all hosts (like <all_urls>) or an api
   // permission that effectively grants access to all hosts (e.g. proxy,
   // network, etc.)
   bool HasEffectiveAccessToAllHosts() const;
@@ skipping 543 matching lines @@
   // only contain the removed permissions.
   const ExtensionPermissionSet* permissions;
 
   UpdatedExtensionPermissionsInfo(
       const Extension* extension,
       const ExtensionPermissionSet* permissions,
       Reason reason);
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_H_