Prevent unnecessary prompts when unpacked extensions use chrome.permissions.request.

chrome/browser/extensions/api/permissions/permissions_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/permissions/permissions_api.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 47 matching lines @@
   ASSERT_TRUE(RunExtensionTest("permissions/favicon")) << message_;
 }
 
 // Test functions and APIs that are always allowed (even if you ask for no
 // permissions).
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, AlwaysAllowed) {
   ASSERT_TRUE(RunExtensionTest("permissions/always_allowed")) << message_;
 }
 
 // Tests that the optional permissions API works correctly.
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, OptionalPermissionsGranted) {

[Yoyo Zhou, 2012/01/24 19:42:23]

Does this test exercise the new functionality? It does look like it's loaded
unpacked.

[jstritar, 2012/01/25 17:34:18]

Yes, because it will only succeed if we've stored granted permissions for the
extension. I also just added a unit test to verify the prompt behavior for LOAD
extensions that have plugins.

   // Mark all the tested APIs as granted to bypass the confirmation UI.
   ExtensionAPIPermissionSet apis;
   apis.insert(ExtensionAPIPermission::kTab);
-  apis.insert(ExtensionAPIPermission::kManagement);
   URLPatternSet explicit_hosts;
-  AddPattern(&explicit_hosts, "http://a.com/*");
   AddPattern(&explicit_hosts, "http://*.c.com/*");
   scoped_refptr<ExtensionPermissionSet> granted_permissions =
       new ExtensionPermissionSet(apis, explicit_hosts, URLPatternSet());
 
   ExtensionPrefs* prefs =
       browser()->profile()->GetExtensionService()->extension_prefs();
   prefs->AddGrantedPermissions("kjmkgkdkpedkejedfhmfcenooemhbpbo",
                                granted_permissions);
 
   RequestPermissionsFunction::SetIgnoreUserGestureForTests(true);
@@ skipping 23 matching lines @@
 }
 
 // Tests that the permissions.request function must be called from within a
 // user gesture.
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, OptionalPermissionsGesture) {
   RequestPermissionsFunction::SetIgnoreUserGestureForTests(false);
   host_resolver()->AddRule("*.com", "127.0.0.1");
   ASSERT_TRUE(StartTestServer());
   EXPECT_TRUE(RunExtensionTest("permissions/optional_gesture")) << message_;
 }