content/browser/site_instance_unittest.cc - Issue 9221017: Hide BrowsingInstance from all but SiteInstance, as intended by design.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/site_instance_unittest.cc

Issue 9221017: Hide BrowsingInstance from all but SiteInstance, as intended by design. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make all methods non-public to help ensure BrowsingInstance design is preserved in future. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/site_instance_unittest.cc

diff --git a/content/browser/site_instance_unittest.cc b/content/browser/site_instance_unittest.cc

index ebb532c353b5a3c024638685ced586484e1668a8..f436471162a6857fbfed408a70587a43632b4442 100644

--- a/content/browser/site_instance_unittest.cc

+++ b/content/browser/site_instance_unittest.cc

@@ -133,6 +133,14 @@ class TestBrowsingInstance : public BrowsingInstance {

use_process_per_site_ = use_process_per_site;

}

+ // Make a few methods public for tests.

+ using BrowsingInstance::ShouldUseProcessPerSite;

+ using BrowsingInstance::browser_context;

+ using BrowsingInstance::HasSiteInstance;

+ using BrowsingInstance::GetSiteInstanceForURL;

+ using BrowsingInstance::RegisterSiteInstance;

+ using BrowsingInstance::UnregisterSiteInstance;

private:

virtual ~TestBrowsingInstance() {

(*delete_counter_)++;