chrome/browser/extensions/extension_host.cc - Issue 9221017: Hide BrowsingInstance from all but SiteInstance, as intended by design.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_host.cc

Issue 9221017: Hide BrowsingInstance from all but SiteInstance, as intended by design. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make all methods non-public to help ensure BrowsingInstance design is preserved in future. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_host.cc

diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc

index 5a8a4c3ccf2a0ebf691e5fe8efe1433b58a8736c..62509c8f3dbcfb9e3d0aff53391e6e448b15775c 100644

--- a/chrome/browser/extensions/extension_host.cc

+++ b/chrome/browser/extensions/extension_host.cc

@@ -31,7 +31,6 @@

#include "chrome/common/extensions/extension_messages.h"

#include "chrome/common/render_messages.h"

#include "chrome/common/url_constants.h"

-#include "content/browser/browsing_instance.h"

#include "content/browser/renderer_host/render_view_host.h"

#include "content/browser/site_instance.h"

#include "content/public/browser/content_browser_client.h"

@@ -123,7 +122,7 @@ ExtensionHost::ExtensionHost(const Extension* extension,

: extension_(extension),

extension_id_(extension->id()),

profile_(Profile::FromBrowserContext(

- site_instance->browsing_instance()->browser_context())),

+ site_instance->GetBrowserContext())),

render_view_host_(NULL),

did_stop_loading_(false),

document_element_available_(false),