Hide BrowsingInstance from all but SiteInstance, as intended by design.

Hide BrowsingInstance from all but SiteInstance, as intended by design.

See comment on BrowsingInstance class that explains it should only be
visible to SiteInstance.  By restoring this design, we also eliminate
one Chrome->Content dependency.

TBR=ben@chromium.org
BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118090

[Jói, 2012-01-17 17:36:38]

jam: Main reviewer.
mpcomplete:  chrome/browser/extensions
ben: chrome/browser/ui/OWNERS rubber stamp

Cheers,
Jói

[Jói, 2012-01-17 17:37:29]

FYI, I updated the change description and subject, which previously said "Hide
BrowsingInstance from all but BrowsingInstance."

Cheers,
Jói

[Charlie Reis, 2012-01-17 19:27:44]

Drive-by: Thanks for this change.  I think it makes a lot of practical sense to
hide BrowsingInstance as long as we don't have a need to expose it, even if it's
actually a top-level concept (i.e., a group of script-connected tabs) and not
really an implementation detail of SiteInstance.  We can expose it later if
there's ever a true need.

[Matt Perry, 2012-01-17 19:35:09]

lgtm

http://codereview.chromium.org/9221017/diff/18/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_process_manager.cc (right):

http://codereview.chromium.org/9221017/diff/18/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_process_manager.cc:159:
Profile::FromBrowserContext(site_instance_->GetBrowserContext());
nit: since you're in here, if you wouldn't mind, could you change this common
pattern to use a GetProfile() helper in this class?

[jam, 2012-01-17 19:37:01]

sweet, lgtm

[Jói, 2012-01-18 10:29:11]

http://codereview.chromium.org/9221017/diff/18/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_process_manager.cc (right):

http://codereview.chromium.org/9221017/diff/18/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_process_manager.cc:159:
Profile::FromBrowserContext(site_instance_->GetBrowserContext());
On 2012/01/17 19:35:09, Matt Perry wrote:
> nit: since you're in here, if you wouldn't mind, could you change this common
> pattern to use a GetProfile() helper in this class?

Done.

[Jói, 2012-01-18 12:29:58]

I'm marking this TBR=ben@chromium.org and asking the CQ to do its thing, since
the chrome/browser/ui changes are trivial.

Cheers,
Jói

[commit-bot: I haz the power, 2012-01-18 12:30:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/9221017/7019

[commit-bot: I haz the power, 2012-01-18 13:39:04]

Change committed as 118090