Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: frog/gen.dart

Issue 9214005: Get Firefox and IE working again with Object.defineProperty! (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/corejs.dart ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/gen.dart
===================================================================
--- frog/gen.dart (revision 3300)
+++ frog/gen.dart (working copy)
@@ -257,15 +257,16 @@
// We special case these two so that by default we can use "= function()"
// syntax for better readability.
if (isOneLiner) {
- ending = ', enumerable: false, configurable: true })' + ending;
+ ending = ', enumerable: false, writable: true, configurable: true })' +
+ ending;
}
writeFunction('Object.defineProperty(${type.jsname}.prototype, "$name",' +
' { value: $functionBody$ending');
if (isOneLiner) return '}';
- return '}, enumerable: false, configurable: true });';
+ return '}, enumerable: false, writable: true, configurable: true });';
} else {
writeFunction(_prototypeOf(type, name) + ' = ' + functionBody + ending);
- return (!isOneLiner) ? '}' : '';
+ return isOneLiner? '': '}';
}
}
« no previous file with comments | « frog/corejs.dart ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698