Get Firefox and IE working again with Object.defineProperty!

frog/corejs.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Generates JS helpers for dart:core. This used to be in a file "core.js".
  * Having them in Dart code means we can easily control which are generated.
  */
 // TODO(jmesserly): one idea to make this cleaner: put these as private "native"
 // methods somewhere in a library that we import. This would be rather elegant
@@ skipping 142 matching lines @@
       w.writeln(opImpl);
     }
 
     if (world.dom != null) {
       ensureTypeNameOf();
       // TODO(jmesserly): we need to find a way to avoid conflicts with other
       // generated "typeName" fields. Ideally we wouldn't be patching 'Object'
       // here.
       w.writeln('Object.defineProperty(Object.prototype, "get\$typeName", ' +
           '{ value: Object.prototype.\$typeNameOf, enumerable: false, ' +
-          'configurable: true});');
+          'writable: true, configurable: true});');
     }
   }
 }
 
 
 /** Snippet for `$ne`. */
 final String _NE_FUNCTION = @"""
 function $ne(x, y) {
   if (x == null) return y != null;
   return (typeof(x) == 'number' && typeof(y) == 'number') ||
          (typeof(x) == 'boolean' && typeof(y) == 'boolean') ||
          (typeof(x) == 'string' && typeof(y) == 'string')
     ? x != y : !x.$eq(y);
 }""";
 
 /** Snippet for `$eq`. */
 final String _EQ_FUNCTION = @"""
 function $eq(x, y) {
   if (x == null) return y == null;
   return (typeof(x) == 'number' && typeof(y) == 'number') ||
          (typeof(x) == 'boolean' && typeof(y) == 'boolean') ||
          (typeof(x) == 'string' && typeof(y) == 'string')
     ? x == y : x.$eq(y);
 }
 // TODO(jimhug): Should this or should it not match equals?
 Object.defineProperty(Object.prototype, '$eq', { value: function(other) { 
-  return this === other; 
-}, enumerable: false, configurable: true });""";
+  return this === other;
+}, enumerable: false, writable: true, configurable: true });""";
 
 /** Snippet for `$bit_not`. */
 final String _BIT_NOT_FUNCTION = @"""
 function $bit_not(x) {
   return (typeof(x) == 'number') ? ~x : x.$bit_not();
 }""";
 
 /** Snippet for `$negate`. */
 final String _NEGATE_FUNCTION = @"""
 function $negate(x) {
@@ skipping 70 matching lines @@
       var table = $dynamicMetadata;
       for (var i = 0; i < table.length; i++) {
         var entry = table[i];
         if (entry.map.hasOwnProperty(tag)) {
           method = methods[entry.tag];
           if (method) break;
         }
       }
     }
     method = method || methods.Object;
-    // Patch the prototype, but don't overwrite an existing stub, like
-    // the one on Object.prototype.
     var proto = Object.getPrototypeOf(obj);
     if (!proto.hasOwnProperty(name)) {
-      Object.defineProperty(proto, name, 
-        { value: method, enumerable: false, configurable: true });
+      Object.defineProperty(proto, name,
+        { value: method, enumerable: false, writable: true, 
+        configurable: true });
     }
 
     return method.apply(this, Array.prototype.slice.call(arguments));
   };
   $dynamicBind.methods = methods;
   Object.defineProperty(Object.prototype, name, { value: $dynamicBind,
-    enumerable: false, configurable: true});
+      enumerable: false, writable: true, configurable: true});
   return methods;
 }
 if (typeof $dynamicMetadata == 'undefined') $dynamicMetadata = [];
 
 function $dynamicSetMetadata(inputTable) {
   // TODO: Deal with light isolates.
   var table = [];
   for (var i = 0; i < inputTable.length; i++) {
     var tag = inputTable[i][0];
     var tags = inputTable[i][1];
@@ skipping 16 matching lines @@
     return this.constructor.name;
   }
   var str = Object.prototype.toString.call(this);
   str = str.substring(8, str.length - 1);
   if (str == 'Window') {
     str = 'DOMWindow';
   } else if (str == 'Document') {
     str = 'HTMLDocument';
   }
   return str;
-}, enumerable: false, configurable: true});""";
+}, enumerable: false, writable: true, configurable: true});""";
 
 /** Snippet for `$inherits`. */
 final String _INHERITS_FUNCTION = @"""
 /** Implements extends for Dart classes on JavaScript prototypes. */
 function $inherits(child, parent) {
   if (child.prototype.__proto__) {
     child.prototype.__proto__ = parent.prototype;
   } else {
     function tmp() {};
     tmp.prototype = parent.prototype;
@@ skipping 46 matching lines @@
 // so many of them. Instead, first time we hit it, put it on the derived
 // prototype. TODO(jmesserly): make this go away by handling index more
 // like a normal method.
 final String _INDEX_OPERATORS = @"""
 Object.defineProperty(Object.prototype, '$index', { value: function(i) {
   var proto = Object.getPrototypeOf(this);
   if (proto !== Object) {
     proto.$index = function(i) { return this[i]; }
   }
   return this[i];
-}, enumerable: false, configurable: true});
+}, enumerable: false, writable: true, configurable: true});
 Object.defineProperty(Array.prototype, '$index', { value: function(i) { 
   return this[i]; 
-}, enumerable: false, configurable: true});
+}, enumerable: false, writable: true, configurable: true});
 Object.defineProperty(String.prototype, '$index', { value: function(i) { 
   return this[i]; 
-}, enumerable: false, configurable: true});""";
+}, enumerable: false, writable: true, configurable: true});""";
 
 /** Snippet for `$setindex` in Object, Array, and String. */
 // TODO(jimhug): Add array bounds checking in checked mode
 /*
 function $inlineArrayIndexCheck(array, index) {
   if (index >= 0 && index < array.length) {
     return index;
   }
   native__ArrayJsUtil__throwIndexOutOfRangeException(index);
 }*/
 final String _SETINDEX_OPERATORS = @"""
 Object.defineProperty(Object.prototype, '$setindex', { value: function(i, value) {
   var proto = Object.getPrototypeOf(this);
   if (proto !== Object) {
     proto.$setindex = function(i, value) { return this[i] = value; }
   }
   return this[i] = value;
-}, enumerable: false, configurable: true});
+}, enumerable: false, writable: true, configurable: true});
 Object.defineProperty(Array.prototype, '$setindex', { value: function(i, value) { 
-  return this[i] = value; }, enumerable: false, configurable: true});""";
+  return this[i] = value; }, enumerable: false, writable: true, 
+  configurable: true});""";
 
 /** Snippet for `$wrap_call$0`. */
 final String _WRAP_CALL0_FUNCTION = @"""
 // Wrap a 0-arg dom-callback to bind it with the current isolate:
 function $wrap_call$0(fn) { return fn && fn.wrap$call$0(); }
 Function.prototype.wrap$call$0 = function() {
   var isolateContext = $globalState.currentContext;
   var self = this;
   this.wrap$0 = function() {
     isolateContext.eval(self);
@@ skipping 24 matching lines @@
 
 /** Snippet for `$wrap_call$1`, in case it was not necessary. */
 final String _EMPTY_WRAP_CALL1_FUNCTION =
     @"function $wrap_call$1(fn) { return fn; }";
 
 /** Snippet that initializes the isolates state. */
 final String _ISOLATE_INIT_CODE = @"""
 var $globalThis = this;
 var $globals = null;
 var $globalState = null;""";