src/heap.cc - Issue 9213002: Fast path for string.replace that replaces a single character by a string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 9213002: Fast path for string.replace that replaces a single character by a string. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index 6295788f0af9a2f4d1e772143ff684362b568d75..7a8f8668fa5dc330d47967da3a09e977de14eb3e 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -3011,7 +3011,7 @@ MaybeObject* Heap::AllocateSubString(String* buffer,

int end,

PretenureFlag pretenure) {

int length = end - start;

- if (length == 0) {

+ if (length <= 0) {

return empty_string();

} else if (length == 1) {

return LookupSingleCharacterStringFromCode(buffer->Get(start));

« no previous file with comments | « no previous file | src/runtime.h » ('j') | no next file with comments »