Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 9212033: Linux/CrOS: Use PR_SET_PTRACER for non-browser crashes. (Closed)

Created:
8 years, 11 months ago by Lei Zhang
Modified:
8 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Linux/CrOS: Use PR_SET_PTRACER for non-browser crashes. BUG=46368, chromium-os:25195 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118927

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M chrome/app/breakpad_linux.cc View 7 chunks +28 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
Hope you don't mind me squeezing in a little bit of code cleanup.
8 years, 11 months ago (2012-01-23 23:05:53 UTC) #1
Michael Krebs
LGTM, although keescook@ should make sure it's correct. I assume this will not cause problems ...
8 years, 11 months ago (2012-01-23 23:24:40 UTC) #2
Lei Zhang
In a private email, keescook@ said: "Yes. On stock kernel it will return -1, errno=ENOSYS. ...
8 years, 11 months ago (2012-01-23 23:29:03 UTC) #3
Kees Cook
lgtm LGTM too. Thanks!
8 years, 11 months ago (2012-01-24 00:46:41 UTC) #4
commit-bot: I haz the power
No LGTM from any valid reviewer yet. Even if a LGTM may have been provided, ...
8 years, 11 months ago (2012-01-24 00:51:19 UTC) #5
Lei Zhang
+mseaborn or agl to stamp this.
8 years, 11 months ago (2012-01-24 01:03:27 UTC) #6
Mark Seaborn
LGTM
8 years, 11 months ago (2012-01-24 05:28:28 UTC) #7
agl
lgtm LGTM
8 years, 11 months ago (2012-01-24 12:17:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9212033/4001
8 years, 11 months ago (2012-01-24 19:54:29 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-24 22:57:45 UTC) #10
Change committed as 118927

Powered by Google App Engine
This is Rietveld 408576698