Make scoped dc objects smarter.

chrome/service/cloud_print/print_system_win.cc

Index: chrome/service/cloud_print/print_system_win.cc
===================================================================
--- chrome/service/cloud_print/print_system_win.cc	(revision 120644)
+++ chrome/service/cloud_print/print_system_win.cc	(working copy)
@@ -410,6 +410,8 @@
             NOTREACHED();

[Peter Kasting, 2012/02/08 00:38:49]

Is it possible for the CreateDC() call to fail legitimately (i.e. in a way we
should handle)?

If so, we should eliminate the NOTREACHED() here.

If not, we should eliminate the entire conditional check and just inline the
CreateDC() call into the Set() call.

[cpu_(ooo_6.6-7.5), 2012/02/10 19:41:55]

Not an expert on printing but I can imagine that if the printer is on the
network this can fail.

             return false;
           }
+          printer_dc_.Set(dc);
+
           hr = E_FAIL;
           DOCINFO di = {0};
           di.cbSize = sizeof(DOCINFO);
@@ -419,7 +421,6 @@
           if (job_id_ <= 0)
             return false;
 
-          printer_dc_.Set(dc);
           saved_dc_ = SaveDC(printer_dc_.Get());
           print_data_file_path_ = print_data_file_path;
           delegate_ = delegate;