Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 9212017: Check in a ninja binary for Linux x64 and Mac. (Closed)

Created:
8 years, 11 months ago by Evan Martin
Modified:
8 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, tony
Visibility:
Public.

Description

Check in a ninja binary for Linux x64 and Mac. The shell script currently just assumes Linux, but can be fixed to run the Mac binary when appropriate. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117723

Patch Set 1 #

Patch Set 2 : mac binary #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --2 lines) Patch
A ninja View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A ninja-linux64 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ninja-mac View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
Should this say "linux" somewhere? I want a checked-in mac binary too, and they can't ...
8 years, 11 months ago (2012-01-13 22:45:24 UTC) #1
Nico
I guess what I'm saying is that I'd add the shelll script now.
8 years, 11 months ago (2012-01-13 22:46:22 UTC) #2
Evan Martin
On 2012/01/13 22:46:22, Nico wrote: > I guess what I'm saying is that I'd add ...
8 years, 11 months ago (2012-01-13 22:50:55 UTC) #3
Nico
Having ninja that looks like #!/bin/sh ninja-linux64 "$@" and the binary having the name ninja-linux64 ...
8 years, 11 months ago (2012-01-13 22:55:28 UTC) #4
Evan Martin
PTAL
8 years, 11 months ago (2012-01-13 23:21:20 UTC) #5
Nico
8 years, 11 months ago (2012-01-13 23:25:57 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698