Issue 92116: Stop debugger by escape key.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92116: Stop debugger by escape key. (Closed)

Created:
11 years, 8 months ago by hamaji

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
chromium-reviews_googlegroups.com, pfeldman

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Stop debugger by escape key. BUG=6890 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14862

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
M	chrome/browser/debugger/debugger_view.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/debugger/debugger_view.cc	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/debugger/debugger_window.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM You should note that the seperate command line debugger will disppear as debugging gets ...

11 years, 8 months ago (2009-04-24 06:14:40 UTC) #2

hamaji

11 years, 8 months ago (2009-04-24 16:59:40 UTC) #3

Thanks you for the review!

On 2009/04/24 06:14:40, Søren Gjesse wrote:
> LGTM
> 
> You should note that the seperate command line debugger will disppear as
> debugging gets integrated into the developer tools.

Ah, I didn't know that. Can we check this in as the devtools isn't enabled by
default for now? If so, could you submit this? I don't have chromium account
yet. Also, could you close the bug?

http://code.google.com/p/chromium/issues/detail?id=6890

Thanks,

Expand Messages | Collapse Messages