Issue 9211020: Don't use command line or prefs for popup saved state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9211020: Don't use command line or prefs for popup saved state (Closed)

Created:
8 years, 11 months ago by stevenjb

Modified:
8 years, 11 months ago

Reviewers:
Ben Goodger (Google), Cem Kocagil

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Don't use command line or prefs for popup saved state The bug is that popup windows are getting opened maximized on linux/gtk because of this call here: http://www.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/ui/gtk/browser_window_gtk.cc&l=1705 It seemed more robust to fix the behavior in Browser::GetSavedWindowShowState(). BUG=106967 TEST=See issue. Also test that maximized state for main browser window is remembered correctly, and --start-maximized works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118174

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/ui/browser.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/9211020/5001

8 years, 11 months ago (2012-01-18 19:30:23 UTC) #2

Change committed as 118174