Add -DENABLE_PLUGIN_INSTALLATION in chrome/renderer.

Add -DENABLE_PLUGIN_INSTALLATION in chrome/renderer.


BUG=62079
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117904

[Bernhard Bauer, 2012-01-16 10:50:17]

Please review.

[jochen (gone - plz use gerrit), 2012-01-16 11:02:14]

http://codereview.chromium.org/9211007/diff/1/chrome/chrome_renderer.gypi
File chrome/chrome_renderer.gypi (right):

http://codereview.chromium.org/9211007/diff/1/chrome/chrome_renderer.gypi#new...
chrome/chrome_renderer.gypi:250: 'ENABLE_PLUGIN_INSTALLATION',
usually that would go into build/common.gypi

[Bernhard Bauer, 2012-01-16 11:04:41]

On 2012/01/16 11:02:14, jochen wrote:
> http://codereview.chromium.org/9211007/diff/1/chrome/chrome_renderer.gypi
> File chrome/chrome_renderer.gypi (right):
> 
>
http://codereview.chromium.org/9211007/diff/1/chrome/chrome_renderer.gypi#new...
> chrome/chrome_renderer.gypi:250: 'ENABLE_PLUGIN_INSTALLATION',
> usually that would go into build/common.gypi

That's what I thought as well, but that only adds the #define for the "common"
target, not for targets which depend on it.

[jochen (gone - plz use gerrit), 2012-01-16 12:38:28]

On 2012/01/16 11:04:41, Bernhard Bauer wrote:
> On 2012/01/16 11:02:14, jochen wrote:
> > http://codereview.chromium.org/9211007/diff/1/chrome/chrome_renderer.gypi
> > File chrome/chrome_renderer.gypi (right):
> > 
> >
>
http://codereview.chromium.org/9211007/diff/1/chrome/chrome_renderer.gypi#new...
> > chrome/chrome_renderer.gypi:250: 'ENABLE_PLUGIN_INSTALLATION',
> > usually that would go into build/common.gypi
> 
> That's what I thought as well, but that only adds the #define for the "common"
> target, not for targets which depend on it.

if you look e.g. at enable_dart, that's also checked there, but results in
WEBKIT_USING_DART defined for webkit/glue/*?

[Bernhard Bauer, 2012-01-17 13:52:49]

On 2012/01/16 12:38:28, jochen wrote:
> On 2012/01/16 11:04:41, Bernhard Bauer wrote:
> > On 2012/01/16 11:02:14, jochen wrote:
> > > http://codereview.chromium.org/9211007/diff/1/chrome/chrome_renderer.gypi
> > > File chrome/chrome_renderer.gypi (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/9211007/diff/1/chrome/chrome_renderer.gypi#new...
> > > chrome/chrome_renderer.gypi:250: 'ENABLE_PLUGIN_INSTALLATION',
> > > usually that would go into build/common.gypi
> > 
> > That's what I thought as well, but that only adds the #define for the
"common"
> > target, not for targets which depend on it.
> 
> if you look e.g. at enable_dart, that's also checked there, but results in
> WEBKIT_USING_DART defined for webkit/glue/*?

Done.

[jochen (gone - plz use gerrit), 2012-01-17 13:59:28]

lgtm, thx

[commit-bot: I haz the power, 2012-01-17 15:06:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/9211007/20001

[commit-bot: I haz the power, 2012-01-17 16:47:35]

Change committed as 117904