Issue 92090: When doing the scheme check for applying V8 extensions, check against the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92090: When doing the scheme check for applying V8 extensions, check against the... (Closed)

Created:
11 years, 8 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, jamesr1

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

When doing the scheme check for applying V8 extensions, check against the activeDocumentLoader's url, not the document's current URL. BUG=10924 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14871

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	webkit/port/bindings/v8/v8_proxy.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Aaron Boodman

11 years, 8 months ago (2009-04-23 22:43:13 UTC) #3

One idea, it might be good to add a comment explaining the importance of using
that loader.