Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: frog/value.dart

Issue 9207022: Fix status file now that the test is fixed. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: another bot fix Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/value.dart
diff --git a/frog/value.dart b/frog/value.dart
index a6da93135285366d25dd8323ea0aa9a13ccb5d22..58b4c8bf120b675df0501582999af5ed2e365fd6 100644
--- a/frog/value.dart
+++ b/frog/value.dart
@@ -1338,11 +1338,9 @@ class VariableValue extends Value {
// these are not really first class
assert(value === null || !value.isType && !value.isSuper);
- // Value should've been converted already
- // TODO(jmesserly): should this setter do the conversion?
- // Or maybe we should we have an "assign" method that returns a Value with
- // code to do the assignment?
- assert(value === null || value.staticType == staticType);
+ // TODO(jmesserly): should we do convertTo here, so the check doesn't get
+ // missed? There are some cases where this assert doesn't hold.
+ // assert(value === null || value.staticType == staticType);
}
static Value _unwrap(Value v) {
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698